-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Push notification grouping #5732
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5732 +/- ##
==========================================
+ Coverage 48.42% 49.55% +1.12%
==========================================
Files 1488 1619 +131
Lines 31617 32139 +522
Branches 7669 7771 +102
==========================================
+ Hits 15311 15926 +615
+ Misses 16238 16150 -88
+ Partials 68 63 -5
... and 508 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally on both iOS and Android by sending a push notification. We can check in production with our beta build everything works as expected.
…een, new DS (#5734)⚠️ This PR depends on #5732⚠️ ⚠️ This PR depends on [io-app-design-system#253](pagopa/io-app-design-system#253)⚠️ ⚠️ This PR depends on [io-app-design-system#256](pagopa/io-app-design-system#256)⚠️ ## Short description This PR aligns the Push Notifications Opt In screen and the profile push notification settings to the new DS |Both on<br/>upper part|Both on<br/>scrolled down|Bottom sheet| |-|-|-| |![On1](https://github.com/pagopa/io-app/assets/5150343/66a756b4-9706-4cda-a20a-b5ebf92e6f1d)|![Simulator Screenshot - iPhone 15 - 2024-05-10 at 12 26 26](https://github.com/pagopa/io-app/assets/5150343/6e6c0ed5-c44c-4e81-ae9c-477ff6e22658)|![OnBS](https://github.com/pagopa/io-app/assets/5150343/9b079428-5262-4f79-b386-bc7e0b6af892)| |Preview Off<br/>Reminder On|Preview On<br/>Reminder Off|Both Off| |-|-|-| |![Pre](https://github.com/pagopa/io-app/assets/5150343/9955c886-ecf5-4401-8e86-7c11a6c7c486)|![Rem](https://github.com/pagopa/io-app/assets/5150343/ea87c7b0-3ca9-435d-993d-2a2994ff9741)|![Off](https://github.com/pagopa/io-app/assets/5150343/0de87ad0-824a-4eca-8251-67ed8ba58ef1)| |Profile<br/>Both on|Profile<br/>Bottom sheet| |-|-| |![ProfileOnPreOnRem](https://github.com/pagopa/io-app/assets/5150343/4bd1d77a-985f-4d8b-89b0-771cedf5ae8c)|![ProfileBS](https://github.com/pagopa/io-app/assets/5150343/a4ab71eb-e5b1-493a-9e4c-d487d1c0e0ec)| |Profile<br/>On Off|Profile<br/>Off On|Profile<br/>Off Off| |-|-|-| |![ProfileOnPreOffRem](https://github.com/pagopa/io-app/assets/5150343/f8fb2554-e94c-46c9-90da-198195d24f28)|![ProfileOffPreOnRem](https://github.com/pagopa/io-app/assets/5150343/4dc52f4a-8165-4495-90cd-771d1009ea63)|![ProfileOffPreOffRem](https://github.com/pagopa/io-app/assets/5150343/494f7064-d6e7-46a2-92c8-5782c161beda)| ## List of changes proposed in this pull request - All related onboarding screens have been ported to the new DS - A lot of test snapshot have been updated due to a change in margins on the DS library ## How to test Using the io-dev-api-server, configure the profile in order to have both `reminder_status` and `push_notifications_content_type` set to undefined. Perform a login and the opt-in screen should appear. Check that both values are properly set after tapping the "Continue" button. For the profile screen, navigate to it and change switches' values
Short description
This PR groups the push-notification's related files into
features/pushNotifications
.List of changes proposed in this pull request
features/pushNotifications
default
exports in favour or direct onesHow to test
Run the application on the physical device and check that everything push-notification-related is working accordingly.