Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-265] Add a new debug screen with the sticky behaviour of the action block #5623

Merged
merged 21 commits into from
May 15, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Mar 25, 2024

Short description

This PR adds a new debug screen with the sticky behaviour of the action block. This screen is intended as a playground to test the feasibility of the functionality in light of the new message detail screen layout.

Known issues:

  • The action block flashes for a few milliseconds at the beginning of the ScrollView when the screen is loaded

List of changes proposed in this pull request

  • Add the new debug screen to the DS navigator
  • Add the new DSStickyMessageCTAs screen component

Preview

sticky-behaviour-message-ctas.mp4

How to test

  1. Go to the Design System section
  2. Scroll the page, gently or not
  3. Try to add different types of buttons (only ButtonSolid, ButtonSolid + ButtonLink, etc…)

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Mar 25, 2024
@dmnplb dmnplb requested a review from a team as a code owner March 25, 2024 14:10
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-265] Add a new debug screen with the sticky behaviour of the action block chore(Cross): [IOAPPX-265] Add a new debug screen with the sticky behaviour of the action block Mar 25, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Mar 25, 2024

Affected stories

  • ⚙️ IOAPPX-265: Comportamento sticky del blocco CTA nel dettaglio dei messaggi
    subtask of

Generated by 🚫 dangerJS against bf1ad9b

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 49.52%. Comparing base (4f204b4) to head (bf1ad9b).
Report is 75 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5623      +/-   ##
==========================================
+ Coverage   48.42%   49.52%   +1.09%     
==========================================
  Files        1488     1603     +115     
  Lines       31617    31886     +269     
  Branches     7669     7651      -18     
==========================================
+ Hits        15311    15792     +481     
+ Misses      16238    16040     -198     
+ Partials       68       54      -14     
Files Coverage Δ
ts/features/design-system/navigation/navigator.tsx 22.85% <ø> (ø)
ts/features/design-system/navigation/routes.ts 100.00% <ø> (ø)
...eatures/design-system/core/DSStickyMessageCTAs.tsx 12.00% <12.00%> (ø)

... and 420 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2da9302...bf1ad9b. Read the comment docs.

Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit 2349078 into master May 15, 2024
13 checks passed
@dmnplb dmnplb deleted the IOAPPX-265-sticky-behavior-cta-block-message-detail branch May 15, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants