Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports switch on "view on github" link #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davorpa
Copy link

@davorpa davorpa commented Aug 8, 2021

Implements feature #61 using github config metadata gem to be compatible with the other page-themes

Screenshot_20210808-075119

Also related with #45 #42 #26 #25 #16 #14 #3

Resolves #61, resolves #45, resolves #42, resolves #26, resolves #25, resolves #16, resolves #14, resolves #3

Implements pages-themes#61 using github config metadata gem
@welcome
Copy link

welcome bot commented Aug 8, 2021

Welcome! Congrats on your first pull request to the Hacker theme. If you haven't already, please be sure to check out the contributing guidelines.

@davorpa davorpa marked this pull request as ready for review August 8, 2021 04:38
@davorpa
Copy link
Author

davorpa commented Aug 8, 2021

@parkr could you approval me to workflow?

My build and test env works fine

Copy link

@Andrewzz Andrewzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@Andrewzz
Copy link

@davorpa It seems that the Pull Request is bugged according to this Stackoverflow question. One suggestion is to close the PR and open it again. Could you try it?

@davorpa davorpa closed this Oct 13, 2021
@davorpa davorpa reopened this Oct 13, 2021
@davorpa davorpa marked this pull request as draft October 13, 2021 00:13
@davorpa davorpa marked this pull request as ready for review October 13, 2021 00:14
@davorpa
Copy link
Author

davorpa commented Oct 13, 2021

It seems that the Pull Request is bugged according to this Stackoverflow question. One suggestion is to close the PR and open it again. Could you try it?

@Andrewzz Thanks!!!

It doesn't work since is my first contribution, I thought. Forcing push with no-edit amend and lease...

@davorpa davorpa force-pushed the feature-61-view-on-github-switcher branch from abbd60f to 7963bab Compare October 13, 2021 00:31
@davorpa
Copy link
Author

davorpa commented Oct 13, 2021

It fail too. 😟 . Let's Github team resolve it with manual rerun.

Maybe there are some problem internally with Probot, #91 has the same state

@Andrewzz
Copy link

Hey @parkr I just read you left GitHub. Do you know who can help with this merge?
Thanks!

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
@davorpa

This comment was marked as off-topic.

@stale stale bot removed the wontfix label Jan 9, 2022
@steftodor
Copy link

bump

1 similar comment
@bisyonary
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants