Extension Generator #468
Extension Generator #468
Conversation
|
Thanks for your contribution! It's really appreciated. We have not yet merged this pull request, because we are currently discussing if Twig should be a Pagekit dependency or not. Best regards |
|
👌 will stand by 👍 |
|
I'd also advise not merging if you come to a consensus to use Twig, as there's open items noted at the bottom of the description. Unless it's okay for this to merge without them. |
|
So, is this still a thing or...? |
| return; | ||
| } else { | ||
| // create the directory for the extension | ||
| mkdir($outputDirectory, 0777, true); |
There was a problem hiding this comment.
777 This is not a little too wide at the levels of rights?
There was a problem hiding this comment.
Probs should be a bit less open than 777
|
What's the status on this? It looks like a great addition |
|
Sorry for not getting back to this PR earlier. I agree this would be a great addition. Also, Twig seems to be here to stay, so it is safe to be used for cases like this. Do you want to update the PR with the suggestions in mind (e.g. change chmod to something less open) and make sure it doesn't have conflicts with |
|
I'll put it on the list for this week, happy to see this moving 😄 |
|
I made a extension before I saw this pull request. 😶 This is definitely a feature I would like to have. 👍 |
This adds support for generating extensions.
This uses twig to template & scaffold out an extension. Template files have been added to a new directory,
app/console/src/Templates/Extensions.Usage
Modeled off the legacy documentation
Example
Disclaimer
There's a few things still to figure out, as I wasn't sure if this was already in development or if there were specific desires, so I didn't want to spend too much time on it past the basics. This would be things like handling default bundle names, etc. The nitty gritty bits. If there is indeed interest in merging this, we can dive into those. Leaving a few todo items here for the completion of this feature: