Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Fix for Dockerfile smell DL3009 #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grosa1
Copy link

@grosa1 grosa1 commented Apr 14, 2023

Hi!
The Dockerfile placed at "proto/Dockerfile" contains the best practice violation DL3009 detected by the hadolint tool.

The smell DL3009 occurs when the apt tool is used to install packages without wiping the cache and source lists.
This pull request proposes a fix for that smell generated by my fixing tool. The generated patch has been manually verified before opening the pull request.
To fix this smell, specifically, the instructions to clean up the apt cache and remove the /var/lib/apt/lists have been added. This helps keep the image size down.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

Signed-off-by: Giovanni Rosa <g.rosa1@studenti.unimol.it>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants