Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jupyter] Deparametrize CI #9931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbonenfant
Copy link
Contributor

This is broken with the current bazel changes, so might as well save some compute time.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.03%. Comparing base (9697f86) to head (badda14).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9931      +/-   ##
==========================================
+ Coverage   58.00%   58.03%   +0.02%     
==========================================
  Files         608      608              
  Lines       73924    73924              
==========================================
+ Hits        42883    42899      +16     
+ Misses      30485    30472      -13     
+ Partials      556      553       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbonenfant bbonenfant requested a review from jrockway April 5, 2024 01:37
@bbonenfant bbonenfant marked this pull request as ready for review April 5, 2024 01:37
Copy link
Member

@jrockway jrockway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine with me if you want to get rid of this, but all you need to do is feed in the version to bazel run <whatever> --@rules_python//python/config_settings:python_version=<the version, like 3.11>

@bbonenfant
Copy link
Contributor Author

Oh I had forgotten that you had worked out how to do this before I went on PTO, let me take another pass at this

@jrockway
Copy link
Member

@bbonenfant One other thing; feel free to add config to .bazelrc that sets the python version. Then people could run anything with any version of Python like bazel --config=py39 ... to use python 3.9. I think the .bazelrc lines would look something like build:py39 --@rules_python//python/config_settings:python_version=3.9 etc. But I haven't actually tried it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants