Move mockpachd's panic handler into a package; use in real and test pachds #9907
+87
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9907 +/- ##
==========================================
- Coverage 58.28% 58.26% -0.03%
==========================================
Files 614 615 +1
Lines 75593 75611 +18
==========================================
- Hits 44060 44051 -9
- Misses 30980 31011 +31
+ Partials 553 549 -4 ☔ View full report in Codecov by Sentry. |
jrockway
force-pushed
the
jonathan/core-2238-loki-in-testpachd
branch
from
37b4b6f
to
f02a218
Compare
jrockway
force-pushed
the
jonathan/panic-interceptor
branch
from
94d5f9d
to
286d989
Compare
jrockway
force-pushed
the
jonathan/panic-interceptor
branch
from
286d989
to
6db04c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the time has come to use this everywhere. While no code should ever panic in production, when it does, it's difficult to debug. (Users just see "EOF" and wonder why their request didn't work.)
The logging interceptor has been updated to upgrade panics to log.LevelError.