Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default workspace to github message marker #3082

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ancosma
Copy link

@ancosma ancosma commented Nov 5, 2023

Fixes #3068

Proposed Changes

  1. Add default workspace to github message marker when it is not same path as github workspace path.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@nvuillam
Copy link
Member

nvuillam commented Nov 5, 2023

Would it be also possible to make such update for gitlab, azure and bitbucket users ? :)

@ancosma
Copy link
Author

ancosma commented Nov 6, 2023

I could try, but since I don't know how other workflows work and which env variables are exposed, I'd like to let the task for someone who uses them actively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Comment Reporter - marker not unique, message is overwritten in monorepo context
2 participants