Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter/eslint): add no_unreachable rule. #3238

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented May 11, 2024

no-unreachable

Status: This one might take a while, Have to resolve some issues with the control flow graph to eliminate false positives, and as of today I couldn't figure out a good solution to resolve all of the shortcomings of our current implementation. This one is an important rule - some might even say essential - and the cfg changes can help with the future development of rules and/or transformers relying on this data; So please bear with me.

Copy link

graphite-app bot commented May 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-ast Area - AST labels May 11, 2024
Copy link
Collaborator Author

rzvxa commented May 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch 2 times, most recently from 57f6ca1 to 94c3001 Compare May 12, 2024 19:41
Copy link

codspeed-hq bot commented May 12, 2024

CodSpeed Performance Report

Merging #3238 will degrade performances by 31.08%

Comparing 05-11-feat_linter_eslint_add_no_unreachable_rule (4b0951e) with main (fdb31c3)

Summary

❌ 2 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 05-11-feat_linter_eslint_add_no_unreachable_rule Change
linter[cal.com.tsx] 3.1 s 4.2 s -25.87%
linter[checker.ts] 5.9 s 8.5 s -31.08%

@rzvxa rzvxa force-pushed the 05-11-feat_linter_eslint_add_no_unreachable_rule branch from 94c3001 to ece1ff3 Compare May 21, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant