Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): @typescript-eslint/consistent-indexed-object-style #3126

Merged

Conversation

todor-a
Copy link
Contributor

@todor-a todor-a commented Apr 29, 2024

@github-actions github-actions bot added the A-linter Area - Linter label Apr 29, 2024
@todor-a todor-a marked this pull request as ready for review April 29, 2024 18:40
Copy link

codspeed-hq bot commented Apr 29, 2024

CodSpeed Performance Report

Merging #3126 will not alter performance

Comparing todor-a:feat-consistent-indexed-object-style (af5b277) with main (6078a6d)

Summary

✅ 22 untouched benchmarks

@Boshen Boshen requested a review from mysteryven April 30, 2024 03:24
@todor-a todor-a requested a review from mysteryven April 30, 2024 18:53
@todor-a todor-a force-pushed the feat-consistent-indexed-object-style branch from 1834331 to 8efa6aa Compare May 19, 2024 10:27
@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier Area - Prettier labels May 19, 2024
@todor-a todor-a force-pushed the feat-consistent-indexed-object-style branch from 8efa6aa to 5a07354 Compare May 19, 2024 10:28
@mysteryven
Copy link
Member

Thanks to your effort on this rule, take your time!

@todor-a
Copy link
Contributor Author

todor-a commented May 24, 2024

Hey, @mysteryven. After some more tinkering I think finally did it. Have another look when you get a chance and let me know what you think.

P.S. I managed to implement a fixer only for one of the settings. I will try to implement it for the other one as well but if not, we can log a separate task.

@mysteryven
Copy link
Member

I will try to implement it for the other one as well but if not, we can log a separate task.

I gonna to merge this first, let's iterate it later :)

And thanks again for all your work.

@mysteryven mysteryven changed the title feat(typescript-lint): implement consistent indexed object style feat(linter): @typescript-eslint/consistent-indexed-object-style May 25, 2024
@mysteryven mysteryven merged commit aa26ce9 into oxc-project:main May 25, 2024
26 checks passed
Boshen pushed a commit that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-codegen Area - Code Generation A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-prettier Area - Prettier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants