Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password messages #1255

Closed

Conversation

AleksaMCode
Copy link

@AleksaMCode AleksaMCode commented Mar 20, 2024

Adds additional messages when dealing with passwords to enhance the UX.

Description

When entering long passwords, users were confronted with a message "Must have capital, small, number & special chars." This would cause confusion with users as the password contained all the needed characters. The long password were rejected because the Regex expression requires passwords to be of a certain length, between 8 and 15 characters in length exactly. However, the end user doesn't know that there are password length limitations and is left to wonder why the password isn't accepted.

With these changes, when registering or changing their password, users will be meet with messages "Password is too short" or "Password is too long" when the password isn't of the appropriate length.

Related Issue

Closes #1170

Motivation and Context

Reviewers

How Has This Been Tested?

Tested manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist:

  • My code follows the code style (modified PEP8) of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@viyatb
Copy link
Member

viyatb commented Apr 14, 2024

@AleksaMCode this will also need a check on the backend side - simply frontend check won't work unless
https://github.com/owtf/owtf/blob/develop/owtf/models/user.py#L19C1-L20C1 is changed.

@viyatb viyatb closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password is marked as "insecure" even though it fits all the requirements.
2 participants