resolves issue #1241 #1242
Open
resolves issue #1241 #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viyatb
requested changes
Feb 28, 2024
owtf/models/user_login_token.py
Outdated
| @@ -28,7 +28,7 @@ def find_by_userid_and_token(cls, session, user_id, token): | |||
| @classmethod | |||
| def add_user_login_token(cls, session, token, user_id): | |||
| """Adds an user_login_token to the DB""" | |||
| new_token = cls(user_id=user_id, token=token.decode("ascii")) | |||
There was a problem hiding this comment.
I would keep the .decode everywhere to handle weird characters - its better to be explicit than implicit :)
viyatb
reviewed
Mar 8, 2024
viyatb
requested changes
Apr 13, 2024
There was a problem hiding this comment.
@Pratham1812 did you test the SimpleCookie implementation to see if it works?
|
I have updated the way cookies ae handled also did the other changes. Could you please have a look? @viyatb |
viyatb
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I have tried fixing #1241 the project now functions with my python version
3.11.8.I have resolved the issue of deprecated dependencies. I have also removed one of the dependencycookiessince it was very outdated, instead i have implemented a one liner approach for the use case of this dependency.I have also fixed the login error which several users were facing :)Description
Related Issue
Motivation and Context
The change tries to run owtf on systems with python versions > 3.9
Reviewers
@viyatb @7a
How Has This Been Tested?
Screenshots (if appropriate):
Application running without docker with python versions 3.11.8
Types of changes
Checklist: