New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otp page UI enhancement #1197
base: develop
Are you sure you want to change the base?
Otp page UI enhancement #1197
Conversation
<img src={logo} alt="brand-logo" /> | ||
</div> | ||
|
||
<h2 className="otpPageContainer__otpComponentContainer__heading"> | ||
We sent a code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the "we sent a code" to "A code was sent to your email" or something like that.
<img src={logo} alt="brand-logo" /> | ||
</div> | ||
<h2 className="loginPageContainer__loginComponentContainer__heading"> | ||
Login with an OWTF Account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just keep Login here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some minor comments!
<link rel="preconnect" href="https://fonts.googleapis.com" /> | ||
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Bebas+Neue&family=Farro:wght@300&family=Heebo:wght@300;400&family=Inter:wght@100;200&family=Source+Sans+Pro&display=swap" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the custom fonts?
Description
Related Issue
Updated the UI of the "OTP" page to get rid of additional dependencies and better user experience
Motivation and Context
Using our own code rather than using the framework gives more flexibility and more precision in implementing the UI.
Reviewers
@7a @sharmamohit123 @viyatb @saganshul
How Has This Been Tested?
I ran the test using the command "npm run test" and all the test cases passed successfully.
Screenshots (please click on the images for better view):
(BEFORE)**
Mobile Design
--
Desktop Design
--
--
(AFTER)
Mobile Design
--
Desktop Design
--
Types of changes
Checklist: