Implement React lazy loading and Upgrade to webpack 4 #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebasing.
viyatb
reviewed
Aug 21, 2021
| "start": "NODE_ENV=development node server", | ||
| "precommit": "pretty-quick --staged", | ||
| "test": "jest", | ||
| "test:watch": "npm test -- --watch" | ||
| "test:watch": "npm test -- --watch", |
There was a problem hiding this comment.
want to use yarn vs npm for consistency?
There was a problem hiding this comment.
Sure I will change it to yarn.
viyatb
requested changes
Aug 21, 2021
|
Sure will rebase and fix the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial load time for the web interface is very large because of the large js file. This is a result of the complete static components loading on the first page itself. My PR aims to resolve the speed issue by removing dead code from the production build of the Webpack and implementing react lazy loading.
Description
Performance comparison before and after using Chrome lighthouse:
Before
After
Motivation and Context
A website experience is defined by how smooth it can function and how fast it can function also this is a step forward in upgrading the project with the latest dependencies.
Reviewers
@viyatb @sharmamohit123
Types of changes
Checklist: