Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1096 #1098

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

EXTREMOPHILARUM
Copy link
Contributor

Description

Fixed the bug that caused logs to not be visible from the worker panel.

Related Issue

#1096

Reviewers

@viyatb

Screenshots (if appropriate):

before
image

after
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other

Checklist:

  • My code follows the code style (modified PEP8) of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sharmamohit123
Copy link
Contributor

lgtm! ^@viyatb

@sharmamohit123
Copy link
Contributor

@EXTREMOPHILARUM right now the same content is being displayed in all the workers log. Can you also fix that please?

@EXTREMOPHILARUM
Copy link
Contributor Author

Sure @sharmamohit123 will take a look at it.

@viyatb
Copy link
Member

viyatb commented Jul 13, 2021

@EXTREMOPHILARUM did you fix what @sharmamohit123 referred to?

@viyatb viyatb closed this Jul 13, 2021
@viyatb viyatb reopened this Jul 13, 2021
@EXTREMOPHILARUM
Copy link
Contributor Author

Yes @viyatb have fixed this issue. Let me push it to this branch.

@EXTREMOPHILARUM
Copy link
Contributor Author

EXTREMOPHILARUM commented Jul 14, 2021

@sharmamohit123 Please verify
cc: @viyatb

@viyatb
Copy link
Member

viyatb commented Aug 15, 2021

@EXTREMOPHILARUM can you rebase?

@EXTREMOPHILARUM
Copy link
Contributor Author

Sure will do

@EXTREMOPHILARUM
Copy link
Contributor Author

@viyatb Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants