This fixes the following scenario: #1020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user is installing owtf and doesn't have tornado installed in its own system, when importing __version__ on setup.py, it will try to load OWTFLogger, that uses tornado, then breaking the application. My fix just bypass that by handling the LoadModule error and installation goes fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user is installing owtf and doesn't have tornado installed in its own system, when importing version on setup.py, it will try to load OWTFLogger, that uses tornado, then breaking the application.
My fix just bypass that by handling the LoadModule error and installation goes fine.
How Has This Been Tested?
Tested on OSX 10.12
Screenshots (if appropriate):
Before:
After:
It's working!
Types of changes