Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two old, minor a11y complaints #10830

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix two old, minor a11y complaints #10830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f896a7
Fix two old, minor a11y complaints
pascalwengerter Apr 24, 2024
343c06a
fix: convert presentational table to definition list
kulmann May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/enhancement-accessibility-improvements
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ Enhancement: Accessibility improvements

Across the board, we have implemented improvements in regards of accessibility for the web UI.

https://github.com/owncloud/web/issues/5379
https://github.com/owncloud/web/issues/5381
https://github.com/owncloud/web/issues/5383
https://github.com/owncloud/web/issues/5391
https://github.com/owncloud/web/issues/10731
https://github.com/owncloud/web/pull/10802
https://github.com/owncloud/web/pull/10830
47 changes: 29 additions & 18 deletions packages/web-app-admin-settings/src/components/General/InfoSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,16 @@
<div>
<h2 class="oc-py-s" v-text="$gettext('Info')" />

<table class="details-table">
<tr>
<th scope="col" class="oc-pr-s" v-text="$gettext('ownCloud')" />
<td v-text="backendProductName" />
</tr>
<tr>
<th scope="col" class="oc-pr-s" v-text="$gettext('Edition')" />
<td v-text="backendEdition" />
</tr>
<tr>
<th scope="col" class="oc-pr-s" v-text="$gettext('Version')" />
<td v-text="backendVersion" />
</tr>
<tr>
<th scope="col" class="oc-pr-s" v-text="$gettext('Web client version')" />
<td v-text="webClientVersion" />
</tr>
</table>
<dl class="details-list">
<dt v-text="$gettext('ownCloud')" />
<dd v-text="backendProductName" />
<dt v-text="$gettext('Edition')" />
<dd v-text="backendEdition" />
<dt v-text="$gettext('Version')" />
<dd v-text="backendVersion" />
<dt v-text="$gettext('Web client version')" />
<dd v-text="webClientVersion" />
</dl>
</div>
</template>

Expand Down Expand Up @@ -55,3 +47,22 @@ export default defineComponent({
}
})
</script>

<style lang="scss">
.details-list {
display: grid;
grid-template-columns: auto minmax(0, 1fr);

dt,
dd {
margin-bottom: var(--oc-space-small);
}
dt {
font-weight: bold;
white-space: nowrap;
}
dd {
margin-inline-start: var(--oc-space-medium);
}
}
</style>
2 changes: 1 addition & 1 deletion packages/web-app-files/src/components/SideBar/Details/FileDetailsMultiple.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</div>
</div>
<div>
<table class="details-table" :aria-label="detailsTableLabel">
<table class="details-table" :aria-label="detailsTableLabel" role="presentation">
<tr data-testid="filesCount">
<th scope="col" class="oc-pr-s oc-font-semibold" v-text="filesText" />
<td v-text="filesCount" />
Expand Down
3 changes: 2 additions & 1 deletion packages/web-pkg/src/components/FilesList/ResourceTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,10 @@
/>
</template>
<template #ddate="{ item }">
<span
<p
v-oc-tooltip="formatDate(item.ddate)"
tabindex="0"
class="oc-m-rm"
v-text="formatDateRelative(item.ddate)"
/>
</template>
Expand Down