fix: space notification links #10603
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes links for incoming space notifications if the user has been added to a new space. Also makes sure links are being removed if a user has been removed from a space and the space had been loaded before.
kulmann
reviewed
Mar 14, 2024
| @@ -175,21 +176,47 @@ export default { | |||
| const space = store.getters['runtime/spaces/spaces'].find( | |||
| (s) => s.fileId === messageRichParameters?.space?.id.split('!')[0] && !s.disabled | |||
| ) | |||
| if (space) { | |||
|
|
|||
| if (space && subject === 'Removed from Space') { | |||
There was a problem hiding this comment.
Isn't the subject translated by the backend? So this would only work for users who have set English as language?
There was a problem hiding this comment.
also... don't we have a different property to check on? Subject is really ugly for this :-(
There was a problem hiding this comment.
Haha yes, totally forgot 🙈 Well, then this is blocked by the server. There is no other way to distinguish between the subjects.
I'll create an issue for it.
|
|
Currently blocked by owncloud/ocis#8645. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes links for incoming space notifications if the user has been added to a new space. Also makes sure links are being removed if a user has been removed from a space and the space had been loaded before.
Related Issue
Types of changes