Skip to content

Commit

Permalink
[tests-only] [full-ci] Remove acceptance test related to image preview (
Browse files Browse the repository at this point in the history
#10670)

* remove acceptance test related to media preview

* address review

* add assertion for media navigation action

* change step description

* select the first element found by locator
  • Loading branch information
Salipa-Gurung committed Apr 26, 2024
1 parent e8c3b22 commit 2a1feec
Show file tree
Hide file tree
Showing 19 changed files with 185 additions and 190 deletions.
2 changes: 0 additions & 2 deletions .drone.star
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ config = {
],
"suites": {
"oCISBasic": [
"webUIPreview",
"webUILogin",
],
"oCISFiles1": [
Expand Down Expand Up @@ -177,7 +176,6 @@ basicTestSuites = [
"webUIFilesDetails",
"webUILogin",
"webUIMoveFilesFolders",
"webUIPreview",
"webUIRenameFiles",
"webUIRenameFolders",
"webUISharingAcceptShares",
Expand Down
136 changes: 0 additions & 136 deletions tests/acceptance/features/webUIPreview/mediaPreview.feature

This file was deleted.

2 changes: 1 addition & 1 deletion tests/e2e/cucumber/features/app-provider/lock.feature
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Feature: lock
Then for "Alice" file "test.odt" should be locked

# checking that sharing/unsharing and creating link of the locked file is possible
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| test.odt | %public% |
And "Alice" shares the following resource using the sidebar panel
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/cucumber/features/app-provider/officeSuites.feature
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Feature: Integrate with online office suites like Collabora and OnlyOffice
When "Alice" creates the following resources
| resource | type | content |
| OpenDocument.odt | OpenDocument | OpenDocument Content |
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | role | password |
| OpenDocument.odt | Can edit | %public% |
And "Alice" logs out
Expand All @@ -29,7 +29,7 @@ Feature: Integrate with online office suites like Collabora and OnlyOffice
When "Alice" creates the following resources
| resource | type | content |
| MicrosoftWord.docx | Microsoft Word | Microsoft Word Content |
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | role | password |
| MicrosoftWord.docx | Can edit | %public% |
And "Alice" logs out
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/cucumber/features/shares/internalLink.feature
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Feature: internal link share
| resource | recipient | type | role |
| myfolder | Brian | user | Can edit |
And "Alice" opens the "files" app
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| myfolder | %public% |
When "Alice" edits the public link named "Link" of resource "myfolder" changing role to "Invited people"
Expand Down
32 changes: 20 additions & 12 deletions tests/e2e/cucumber/features/shares/link.feature
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Feature: link
| folderPublic/lorem.txt | lorem ipsum |

And "Alice" opens the "files" app
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | role | password |
| folderPublic | Secret File Drop | %public% |
And "Alice" renames the most recently created public link of resource "folderPublic" to "myPublicLink"
Expand Down Expand Up @@ -86,33 +86,38 @@ Feature: link
| localFile | to |
| filesForUpload/simple.pdf | simple.pdf |
| filesForUpload/testavatar.jpg | testavatar.jpg |
| filesForUpload/test_video.mp4 | test_video.mp4 |
And "Alice" shares the following resource using API
| resource | recipient | type | role |
| folderPublic | Brian | user | Can edit |
| simple.pdf | Brian | user | Can edit |
| testavatar.jpg | Brian | user | Can edit |

And "Alice" opens the "files" app
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| folderPublic | %public% |
And "Alice" renames the most recently created public link of resource "folderPublic" to "folderLink"
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| folderPublic/shareToBrian.txt | %public% |
And "Alice" renames the most recently created public link of resource "folderPublic/shareToBrian.txt" to "textLink"
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| folderPublic/shareToBrian.md | %public% |
And "Alice" renames the most recently created public link of resource "folderPublic/shareToBrian.md" to "markdownLink"
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| simple.pdf | %public% |
And "Alice" renames the most recently created public link of resource "simple.pdf" to "pdfLink"
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| testavatar.jpg | %public% |
And "Alice" renames the most recently created public link of resource "testavatar.jpg" to "imageLink"
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| test_video.mp4 | %public% |
And "Alice" renames the most recently created public link of resource "test_video.mp4" to "videoLink"
And "Alice" logs out

# authenticated user with access to resources. should be redirected to shares with me page
Expand Down Expand Up @@ -146,7 +151,7 @@ Feature: link
When "Brian" opens the public link "imageLink"
And "Brian" unlocks the public link with password "%public%"
# https://github.com/owncloud/ocis/issues/8602
Then "Brian" is in a image-viewer
Then "Brian" is in a media-viewer
And "Brian" closes the file viewer
And "Brian" downloads the following public link resources using the single share view
| resource | type |
Expand Down Expand Up @@ -181,8 +186,7 @@ Feature: link
| simple.pdf | file |
When "Carol" opens the public link "imageLink"
And "Carol" unlocks the public link with password "%public%"
# https://github.com/owncloud/ocis/issues/8602
Then "Carol" is in a image-viewer
Then "Carol" is in a media-viewer
And "Carol" closes the file viewer
And "Carol" downloads the following public link resources using the single share view
| resource | type |
Expand Down Expand Up @@ -216,11 +220,15 @@ Feature: link
When "Anonymous" opens the public link "imageLink"
And "Anonymous" unlocks the public link with password "%public%"
# https://github.com/owncloud/ocis/issues/8602
Then "Anonymous" is in a image-viewer
Then "Anonymous" is in a media-viewer
And "Anonymous" closes the file viewer
And "Anonymous" downloads the following public link resources using the single share view
| resource | type |
| testavatar.jpg | file |
When "Anonymous" opens the public link "videoLink"
And "Anonymous" unlocks the public link with password "%public%"
Then "Anonymous" is in a media-viewer
And "Anonymous" closes the file viewer


Scenario: add banned password for public link
Expand All @@ -230,7 +238,7 @@ Feature: link
| lorem.txt | some text |

And "Alice" opens the "files" app
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | password |
| lorem.txt | %public% |
When "Alice" tries to sets a new password "ownCloud-1" of the public link named "Link" of resource "lorem.txt"
Expand Down Expand Up @@ -263,7 +271,7 @@ Feature: link
| pathToFile | content |
| folderPublic/lorem.txt | lorem ipsum |
And "Alice" opens the "files" app
And "Alice" creates a public link creates a public link of following resource using the sidebar panel
And "Alice" creates a public link of following resource using the sidebar panel
| resource | role | password |
| folderPublic | Can edit | %public% |
And "Alice" renames the most recently created public link of resource "folderPublic" to "myPublicLink"
Expand Down

0 comments on commit 2a1feec

Please sign in to comment.