Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add support for link share preview #475

Closed
wants to merge 3 commits into from
Closed

WIP: add support for link share preview #475

wants to merge 3 commits into from

Conversation

mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Aug 15, 2022 •
edited

WARNING: do not merge, yet this is in Proof of Concept state only

Screenshot 2022-08-15 at 21 51 56
Screenshot 2022-08-15 at 21 52 38
Screenshot 2022-08-15 at 21 52 53
Screenshot 2022-08-15 at 21 59 03

@mrow4a mrow4a self-assigned this Aug 15, 2022
AlexAndBear
AlexAndBear approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me the wording 'Preview' is very misleading, I would vote for 'View only' at least in the UI.
Other than that, LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mrow4a mrow4a changed the title add support for link share preview WIP: add support for link share preview Sep 17, 2022
@NannaBarz
Copy link

@mrow4a what should we do here in the Serverteam board?

@mrow4a
Copy link
Contributor Author

mrow4a commented Oct 10, 2022

@NannaBarz decide whether we want to have this feature or not.. ref. https://github.com/owncloud/enterprise/issues/5277

This was referenced Jul 7, 2023
Closed
Closed
@jnweiger
Copy link
Contributor

jnweiger commented Aug 1, 2023

@hodyroff this is not in the richdcuments 4.0.0 release ticket. Should it be added?

@mrow4a
Copy link
Contributor Author

mrow4a commented Aug 1, 2023

@jnweiger this here was PoC. Also requires Core change.

@pako81
Copy link
Contributor

pako81 commented Aug 1, 2023 •
edited

@mrow4a would it be a lot of effort to finalize this + owncloud/core#40289 based on the original approach? Would be very nice to have this in core 10.13 + richdocuments 4.0.0.

@pako81
Copy link
Contributor

pako81 commented Oct 11, 2023

@mrow4a @hodyroff @jnweiger should we consider moving this forward now?

@hodyroff
Copy link

No, good POC. But the use case for secure view/no download are very secret documents. Why would a user show those through public links, rather then accounts which can be audited and tracked? We continue the work when this comes up as a requirement again.

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Oct 17, 2023 •
edited

@hodyroff initial Request is not actual anymore ? If so, I'd also avoid this feature or disable it by default.

@hodyroff
Copy link

hodyroff commented Oct 17, 2023 •
edited by AlexAndBear

Yes, not valid anymore.

@DeepDiver1975 DeepDiver1975 deleted the e5277 branch October 17, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@mrow4a mrow4a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mrow4a @NannaBarz @jnweiger @pako81 @hodyroff @AlexAndBear @DeepDiver1975