Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manipulate share type for oc10 guests #1046

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Manipulate share type for oc10 guests #1046

merged 3 commits into from
Apr 26, 2022

Conversation

AlexAndBear
Copy link
Contributor

No description provided.

@AlexAndBear AlexAndBear changed the title Manipulate share type Manipulate share type for oc10 guests Apr 25, 2022
@AlexAndBear AlexAndBear mentioned this pull request Apr 25, 2022
Closed
kulmann
kulmann reviewed Apr 25, 2022
View reviewed changes
src/shareInfo.js Outdated Show resolved Hide resolved
kulmann
kulmann reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good. But the linter is screaming and the changelog is empty. 😁

@AlexAndBear
Copy link
Contributor Author

Code itself looks good. But the linter is screaming and the changelog is empty. grin

DRAFT DRAFT DRAFT :D :D :D
I even wasn't able to check if it works, as stuff in the other pr is failing :P

AlexAndBear
AlexAndBear commented Apr 26, 2022
View reviewed changes
src/shareInfo.js
Comment on lines -12 to -13
// Below keys don't need to be stored
const notNeededKeys = ['item_type', 'item_source', 'file_source', 'parent', 'storage', 'mail_send']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the storage, and I have no idea, why we should purge those properties

@AlexAndBear AlexAndBear marked this pull request as ready for review April 26, 2022 10:39
kulmann
kulmann approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks regarding changelog and code comments. the code looks good 👍

changelog/unreleased/enhancement-enforce-share-type-guest-if-applies Outdated Show resolved Hide resolved
src/shareInfo.js Outdated Show resolved Hide resolved
src/shareManagement.js Outdated Show resolved Hide resolved
AlexAndBear and others added 2 commits April 26, 2022 16:00
@AlexAndBear
Prosa klimber bims
a90eae4
@AlexAndBear @kulmann
Update changelog/unreleased/enhancement-enforce-share-type-guest-if-a…
1bd05b2 
…pplies

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 77ab4c0 into master Apr 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the manipulate-share-type branch April 26, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexAndBear @kulmann