fix: service startup appprovider onlyoffice #9127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
butonic
approved these changes
May 10, 2024
ownclouders
pushed a commit
that referenced
this pull request
May 10, 2024
fix: service startup appprovider onlyoffice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the ocis wopi example after it was broken since #8984
@DeepDiver1975 The appprovider-onlyoffice was starting a second ocis fullstack service and the service registry was used from the ocis container. This broke a lot of service registrations. The services from the app-provider were registered after the ones from the ocis container but the requests were routed to the ocis container while the "real services" were running in the app-provider container.
@wkloucek @d7oc Interesting. First accidental use of two full stack ocis servers side by side 馃槃
Fixes: #9111
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: