[tests-only] code review of acceptance tests

[phil-davis]

Description

Tidy up some things in the acceptance test code, such as:

• declare variables where the IDE thinks that they may not be set
• remove unused private vars in classes
• update PHPdoc of functions to match reality
• declare all parameter and return types
• fixup some Behat step functions that did not use some parameter(s). Mostly add ?: in the step regex so that the not-needed item is not passed through as a parameter.
• use print_r() in cases where we are generating a test-failure message including something that might be an array.
• do not provide default values for private vars that already have their type declared (current PHP already provides those default values without needing to specify them)
• delete functions that are not used (I have only deleting the ones that are "obviously" not used any more, another pass through the code can be done some time to remove more dead code)
• make sure that all functions will always return what they are declared to return
• fix small typos and grammar

Related Issue

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[saw-jan]

LGTM. some SharingNG tests were failing, restarted the CI

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud