[tests-only][full-ci]Add tests for update shares using root endpoint #8906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
add-tests-for-share-invite-for-drives
branch
3 times, most recently
from
d272f91
to
46b2541
Compare
amrita-shrestha
changed the base branch from
add-tests-for-share-invite-for-drives
to
master
amrita-shrestha
force-pushed
the
add-tests-for-update-shares-using-root-endpoint
branch
from
b81742b
to
8b9c623
Compare
7 tasks
amrita-shrestha
force-pushed
the
add-tests-for-update-shares-using-root-endpoint
branch
from
8b9c623
to
814d823
Compare
amrita-shrestha
requested review from
grgprarup,
SagarGi,
saw-jan,
Salipa-Gurung,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
29 tasks
amrita-shrestha
force-pushed
the
add-tests-for-update-shares-using-root-endpoint
branch
from
814d823
to
72f39ad
Compare
saw-jan
reviewed
May 6, 2024
Comment on lines
+982
to
+992
| /** | ||
| * @Given /^user "([^"]*)" has sent the following share invitation using root endpoint of the Graph API:$/ | ||
| * | ||
| * @param string $user | ||
| * @param TableNode $table | ||
| * | ||
| * @return void | ||
| * @throws GuzzleException | ||
| */ | ||
| public function userHasSentTheFollowingShareInvitationUsingRootEndPointTheGraphApi(string $user, TableNode $table): void { | ||
| $this->sendSharingInvitationForDrive($user, $table); |
There was a problem hiding this comment.
we should use the root endpoint for drive share in Given steps. we have to update the existing step
There was a problem hiding this comment.
someone could work on next PR if you want to change that this PR is for update share using root endpoint. So let's not make PR too big
tests/acceptance/features/apiSharingNg/updateShareInvitations.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiSharingNg/updateShareInvitations.feature
Outdated
Show resolved
Hide resolved
amrita-shrestha
force-pushed
the
add-tests-for-update-shares-using-root-endpoint
branch
from
72f39ad
to
a6f0a91
Compare
|
saw-jan
approved these changes
May 8, 2024
delete-merged-branch
bot
deleted the
add-tests-for-update-shares-using-root-endpoint
branch
ownclouders
pushed a commit
that referenced
this pull request
May 8, 2024
DeepDiver1975
pushed a commit
that referenced
this pull request
May 8, 2024
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for updating expiration and role of shared project
Related Issue
/graph/v1beta1/drives/{driveId}/rootendpoint #8810Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: