Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Add tests for update shares using root endpoint #8906

Merged
merged 1 commit into from May 8, 2024

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Apr 19, 2024

Description

This PR adds tests for updating expiration and role of shared project

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Apr 19, 2024
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-share-invite-for-drives branch 3 times, most recently from d272f91 to 46b2541 Compare April 26, 2024 04:29
@delete-merged-branch delete-merged-branch bot deleted the branch master April 26, 2024 06:41
@amrita-shrestha amrita-shrestha changed the base branch from add-tests-for-share-invite-for-drives to master April 30, 2024 04:26
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-update-shares-using-root-endpoint branch from b81742b to 8b9c623 Compare May 3, 2024 06:56
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-update-shares-using-root-endpoint branch from 8b9c623 to 814d823 Compare May 3, 2024 06:59
@amrita-shrestha amrita-shrestha marked this pull request as ready for review May 3, 2024 06:59
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-update-shares-using-root-endpoint branch from 814d823 to 72f39ad Compare May 3, 2024 11:06
tests/TestHelpers/GraphHelper.php Outdated Show resolved Hide resolved
Comment on lines +982 to +992
/**
* @Given /^user "([^"]*)" has sent the following share invitation using root endpoint of the Graph API:$/
*
* @param string $user
* @param TableNode $table
*
* @return void
* @throws GuzzleException
*/
public function userHasSentTheFollowingShareInvitationUsingRootEndPointTheGraphApi(string $user, TableNode $table): void {
$this->sendSharingInvitationForDrive($user, $table);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use the root endpoint for drive share in Given steps. we have to update the existing step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone could work on next PR if you want to change that this PR is for update share using root endpoint. So let's not make PR too big

tests/acceptance/features/bootstrap/SharingNgContext.php Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the add-tests-for-update-shares-using-root-endpoint branch from 72f39ad to a6f0a91 Compare May 6, 2024 04:29
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 545624f into master May 8, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-tests-for-update-shares-using-root-endpoint branch May 8, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants