Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for listing permission of shares drive #8904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[tests-only][full-ci] adding test for listing permission of shares drive #8904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/acceptance/features/apiSharingNg/listPermissions.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,3 +1079,24 @@ Feature: List a sharing permissions
| drive |
| Personal |
| Shares |


Scenario: user lists the permissions of their shares drive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario: user lists the permissions of their shares drive
Scenario: user lists the permissions of Shares drive (permissions endpoint)

When user "Alice" lists the permissions of space "Shares" using the Graph API
Then the HTTP status code should be "200"
And the JSON data of the response should match
"""
Comment on lines +1085 to +1088
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor we have two APIs for listing permission for drives i.e.:

  1. https://owncloud.dev/libre-graph-api/#/drives.root/ListPermissionsSpaceRoot
  2. https://owncloud.dev/libre-graph-api/#/drives.permissions/ListPermissions

imo those API should should give same output but. when listing permission of shares space
we get different response

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need clarification/confirmation

CC @rhafer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made an issue regarding this #8922

{
"type": "object",
"required": [
"@libre.graph.permissions.roles.allowedValues"
],
"properties": {
"value": {
"type": "array",
"minItems": 0,
"maxItems": 0
}
}
}
"""