Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding test for listing permission of personal drive #8901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nirajacharya2
Copy link
Contributor

Description

this pr adds test for listing permissions of personal drive

added scenarios

Scenario: user lists the permissions of their personal spaces

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +1084 to +1085
Scenario: user lists the permissions of their personal spaces
When user "Alice" lists the permissions of space "Personal" using the Graph API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response is different from using drives.root endpoint. Needs clarifications here.

Should listing permissions of Personal space's root path be possible?
this step uses drives.permissions. : drives/<drive-id>/items/<root-path-id>/permissions

CC @ScharfViktor @rhafer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using drives.root endpoint, it is not possible to list Personal space permissions

Scenario Outline: try to lists the permissions of a Personal/Shares drive using root endpoint
Given using spaces DAV path
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
When user "Alice" tries to list the permissions of space "<drive>" using root endpoint of the Graph API
Then the HTTP status code should be "400"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made an issue regarding this #8922



Scenario: user lists the permissions of their personal spaces
When user "Alice" lists the permissions of space "Personal" using the Graph API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirajacharya2 Could you rename this as:

Suggested change
When user "Alice" lists the permissions of space "Personal" using the Graph API
When user "Alice" lists the permissions of space "Personal" using permissions endpoint of the Graph API

@@ -1079,3 +1079,122 @@ Feature: List a sharing permissions
| drive |
| Personal |
| Shares |


Scenario: user lists the permissions of their personal spaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario: user lists the permissions of their personal spaces
Scenario: user lists the permissions of Personal spaces (permissions endpoint)

@nirajacharya2
Copy link
Contributor Author

currently blocked by #8922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants