Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] do not try to delete already deleted groups #8886

Merged
merged 4 commits into from
Apr 18, 2024
Merged

[tests-only] do not try to delete already deleted groups #8886

merged 4 commits into from
Apr 18, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Apr 18, 2024 •
edited

Description

Do not try to delete already deleted groups

Fixes this error in AfterScenario hooks:

│
  ╳  HTTP status code 404 is not the expected value 204
  ╳  Failed asserting that 404 matches expected 204.
  │
  └─ @AfterScenario # FeatureContext::afterScenario()

Related Issue

#8864

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Apr 18, 2024
@saw-jan saw-jan force-pushed the tests/fix-flaky-sharing-tests branch from bfda0a6 to 4b181cb Compare April 18, 2024 08:53
@saw-jan saw-jan marked this pull request as ready for review April 18, 2024 08:55
@saw-jan saw-jan marked this pull request as draft April 18, 2024 09:43
@saw-jan
Copy link
Member Author

saw-jan commented Apr 18, 2024 •
edited

Still some errors left Fixed

@saw-jan saw-jan force-pushed the tests/fix-flaky-sharing-tests branch from 4b181cb to 8f094ef Compare April 18, 2024 10:24
@saw-jan saw-jan marked this pull request as ready for review April 18, 2024 10:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 2f32fa3 into master Apr 18, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/fix-flaky-sharing-tests branch April 18, 2024 11:43
ownclouders pushed a commit that referenced this pull request Apr 18, 2024
@saw-jan
[tests-only] do not try to delete already deleted groups (#8886)
bd51f4a 
* fix(test): do not try to delete already deleted groups

* test: remove redundant steps

* test: fix php code style

* fix typo
@S-Panta S-Panta mentioned this pull request May 10, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saw-jan @phil-davis