Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for listing permission of a project space #8551

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[tests-only][full-ci] adding test for listing permission of a project space #8551

merged 1 commit into from
Mar 4, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Mar 1, 2024 •
edited

Description

adding test for listing permission of a project space

Scenario: user lists permissions of a project space via the Graph API

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Mar 1, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Mar 1, 2024
Closed
18 tasks
@nirajacharya2 nirajacharya2 marked this pull request as ready for review March 1, 2024 06:01
grgprarup
grgprarup approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nirajacharya2 nirajacharya2 force-pushed the list-perm-space-with-space-id branch 2 times, most recently from 19eec58 to f4f29e7 Compare March 4, 2024 10:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit 28d53fe into master Mar 4, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the list-perm-space-with-space-id branch March 4, 2024 11:09
ownclouders pushed a commit that referenced this pull request Mar 4, 2024
@nirajacharya2
adding test for listing permission of a project space (#8551)
ee6a244
rhafer pushed a commit to rhafer/ocis that referenced this pull request Mar 12, 2024
@nirajacharya2 @rhafer
adding test for listing permission of a project space (owncloud#8551)
deac05a 
(cherry picked from commit 28d53fe)
@rhafer rhafer mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup approved these changes

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nirajacharya2 @grgprarup @saw-jan @PrajwolAmatya