Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Added tests for sharing with all allowed roles for the list permissions #8477

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Feb 16, 2024

Description

This PR adds a tests to share invitation for all the allowed roles that are listed from the permission list for sharingNG for a file and a folder.

Scenario: user send share invitation for all allowed roles defined in permission lists for a file
Scenario: user send share invitation for all allowed roles defined in permission lists for a folder

Related Issue:

#8336

@SagarGi
Copy link
Member Author

SagarGi commented Feb 21, 2024

This PR is blocked until what is expected in the response. An issue regarding it it made here #8331. So putting it in blocked until it gets fixed.

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SagarGi SagarGi marked this pull request as ready for review February 21, 2024 08:27
@nabim777 nabim777 marked this pull request as draft March 25, 2024 05:38
@SagarGi SagarGi force-pushed the SharingNg/check_allowed_roles branch 2 times, most recently from e349a5c to 0b1816f Compare April 15, 2024 10:23
@SagarGi SagarGi requested a review from saw-jan April 15, 2024 10:50
@SagarGi SagarGi marked this pull request as ready for review April 15, 2024 10:50
@SagarGi SagarGi force-pushed the SharingNg/check_allowed_roles branch from d1adc52 to cf9e4ce Compare April 16, 2024 03:59
@SagarGi SagarGi requested a review from saw-jan April 16, 2024 04:00
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
@SagarGi SagarGi force-pushed the SharingNg/check_allowed_roles branch 2 times, most recently from b83ce11 to 56ed59b Compare April 17, 2024 04:24
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
@SagarGi SagarGi force-pushed the SharingNg/check_allowed_roles branch from 56ed59b to 349b2c0 Compare April 17, 2024 04:26
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 0972b7c into master Apr 17, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the SharingNg/check_allowed_roles branch April 17, 2024 06:15
ownclouders pushed a commit that referenced this pull request Apr 17, 2024
…or the list permissions (#8477)

* Added tests for sharing with all allowed roles for the list permissions

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* Refactor code

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* Rebase and refactor code

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* Review address

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* Rebase code

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

---------

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants