Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-accepting is slow in CI #8859

Open
ScharfViktor opened this issue Apr 15, 2024 · 8 comments
Open

Auto-accepting is slow in CI #8859

ScharfViktor opened this issue Apr 15, 2024 · 8 comments
Assignees
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Apr 15, 2024

https://drone.owncloud.com/owncloud/ocis/33724/32/6
https://drone.owncloud.com/owncloud/ocis/33662/27/5
https://drone.owncloud.com/owncloud/ocis/33734/32/6

Steps:

  • user1 shares file
  • user2 send GET https://localhost:9200/graph/v1beta1/me/drive/sharedWithMe

Actual: share should be accepted. @client.synchronize: true

I have not been able to reproduce this locally. I don't see any problems on the testing side. adding a waiting to the test may solve the problem but seems like a poor solution to the problem

@saw-jan
Copy link
Member

saw-jan commented Apr 16, 2024

Similar to #8864

Also, have to revert 4e66cc7 if suitable fix is found

@saw-jan saw-jan added QA:team and removed Type:Bug labels Apr 16, 2024
@ScharfViktor
Copy link
Contributor Author

auto-accepting is an asynchronous process, so sometimes share does not have time to be accepted. This applies only to the first scenario from the feature file.

I tried to fix here 4e66cc7

step user "Brian" lists the shares shared with him after clearing user cache using the Graph API has 1 sec sleep

@saw-jan
Copy link
Member

saw-jan commented Apr 25, 2024

Failed in other scenarios as well
https://drone.owncloud.com/owncloud/ocis/33884/32/6

Scenario: user lists folder shared with them in a group from sharer's personal space      # /drone/src/tests/acceptance/features/apiSharingNg/sharedWithMe.feature:2498
    Given using spaces DAV path                                                             # FeatureContext::usingOldOrNewDavPath()
    And the administrator has assigned the role "Admin" to user "Alice" using the Graph API # GraphContext::theAdministratorHasGivenTheRoleUsingTheGraphApi()
    And user "Alice" has created folder "folder"                                            # FeatureContext::userHasCreatedFolder()
    And user "Alice" has created a group "grp1" using the Graph API                         # GraphContext::userHasCreatedGroupUsingTheGraphApi()
    And user "Brian" has been added to group "grp1"                                         # FeatureContext::userHasBeenAddedToGroup()
    And user "Alice" has sent the following share invitation:                               # SharingNgContext::userHasSentTheFollowingShareInvitation()
      | resource        | folder   |
      | space           | Personal |
      | sharee          | grp1     |
      | shareType       | group    |
      | permissionsRole | Viewer   |
    When user "Brian" lists the shares shared with him using the Graph API                  # GraphContext::userListsTheResourcesSharedWithThemUsingGraphApi()
    Then the HTTP status code should be "200"                                               # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the JSON data of the response should match
Enum failed, enum: [true], data: false at #->properties:value->items[0]:0->properties:@client.synchronize (Swaggest\JsonSchema\Exception\EnumException)

Scenario: user lists the file shared with them from project space                                             # /drone/src/tests/acceptance/features/apiSharingNg/sharedWithMe.feature:3544
    Given using spaces DAV path                                                                                 # FeatureContext::usingOldOrNewDavPath()
    And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API               # GraphContext::theAdministratorHasGivenTheRoleUsingTheGraphApi()
    And user "Alice" has created a space "new-space" with the default quota using the Graph API                 # SpacesContext::theUserHasCreatedASpaceByDefaultUsingTheGraphApi()
    And user "Alice" has uploaded a file inside space "new-space" with content "some content" to "testfile.txt" # SpacesContext::userHasUploadedFile()
    And user "Alice" has sent the following share invitation:                                                   # SharingNgContext::userHasSentTheFollowingShareInvitation()
      | resource        | testfile.txt |
      | space           | new-space    |
      | sharee          | Brian        |
      | shareType       | user         |
      | permissionsRole | Viewer       |
    When user "Brian" lists the shares shared with him using the Graph API                                      # GraphContext::userListsTheResourcesSharedWithThemUsingGraphApi()
    Then the HTTP status code should be "200"                                                                   # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the JSON data of the response should match
Const failed at #->properties:value->items[0]:0->properties:@client.synchronize (Swaggest\JsonSchema\Exception\ConstException)

@saw-jan
Copy link
Member

saw-jan commented May 6, 2024

Closing
See #8891 (comment)

@saw-jan saw-jan closed this as completed May 6, 2024
@S-Panta
Copy link
Contributor

S-Panta commented May 7, 2024

Fails in https://drone.owncloud.com/owncloud/ocis/34650/33/5

Scenario: sharee lists the file share (Project space)                                                         # /drone/src/tests/acceptance/features/apiSharingNg/sharedWithMe.feature:2502
    Given using spaces DAV path                                                                                 # FeatureContext::usingOldOrNewDavPath()
    And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API               # GraphContext::theAdministratorHasGivenTheRoleUsingTheGraphApi()
    And user "Alice" has created a space "new-space" with the default quota using the Graph API                 # SpacesContext::theUserHasCreatedASpaceByDefaultUsingTheGraphApi()
    And user "Alice" has uploaded a file inside space "new-space" with content "some content" to "testfile.txt" # SpacesContext::userHasUploadedFile()
    And user "Alice" has sent the following share invitation:                                                   # SharingNgContext::userHasSentTheFollowingShareInvitation()
      | resource        | testfile.txt |
      | space           | new-space    |
      | sharee          | Brian        |
      | shareType       | user         |
      | permissionsRole | Viewer       |
    When user "Brian" lists the shares shared with him using the Graph API                                      # GraphContext::userListsTheResourcesSharedWithThemUsingGraphApi()
    Then the HTTP status code should be "200"                                                                   # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the JSON data of the response should match  
Enum failed, enum: [true], data: false at #->properties:value->items[0]:0->properties:@client.synchronize (Swaggest\JsonSchema\Exception\EnumException)

@grgprarup
Copy link
Contributor

@saw-jan
Copy link
Member

saw-jan commented May 14, 2024

I will look at it once again.

@saw-jan saw-jan reopened this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants