Skip to content

Commit

Permalink
Review addres
Browse files Browse the repository at this point in the history
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
  • Loading branch information
SagarGi committed Apr 26, 2024
1 parent ec08141 commit 1d5b771
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions tests/acceptance/features/apiSharingNg/listPermissions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ Feature: List a sharing permissions
And user "Brian" has been created with default attributes and without skeleton files
When user "Alice" gets permissions list for file "textfile.txt" of the space "Personal" using the Graph API
Then the HTTP status code should be "200"
And user "Alice" should be able to send share invitation with all allowed permission roles
And user "Alice" should be able to send share the following invitation with all allowed permission roles
| resource | textfile.txt |
| space | Personal |
| sharee | Brian |
Expand All @@ -908,7 +908,7 @@ Feature: List a sharing permissions
And user "Brian" has been created with default attributes and without skeleton files
When user "Alice" gets permissions list for folder "folder" of the space "Personal" using the Graph API
Then the HTTP status code should be "200"
And user "Alice" should be able to send share invitation with all allowed permission roles
And user "Alice" should be able to send share the following invitation with all allowed permission roles
| resource | folder |
| space | Personal |
| sharee | Brian |
Expand Down Expand Up @@ -1081,14 +1081,14 @@ Feature: List a sharing permissions
| Shares |


Scenario: space admin share invitation with all allowed roles for a project space
Scenario: space admin invites to a project space with all allowed roles
Given using spaces DAV path
And the administrator has assigned the role "Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
And user "Brian" has been created with default attributes and without skeleton files
When user "Alice" lists the permissions of space "new-space" using the Graph API
When user "Alice" lists the permissions of space "new-space" using permissions endpoint of the Graph API
Then the HTTP status code should be "200"
And user "Alice" should be able to send share invitation with all allowed permission roles
And user "Alice" should be able to send share the following invitation with all allowed permission roles
| space | new-space |
| sharee | Brian |
| shareType | user |
Expand All @@ -1102,7 +1102,7 @@ Feature: List a sharing permissions
And user "Brian" has been created with default attributes and without skeleton files
When user "Alice" gets permissions list for file "textfile.txt" of the space "new-space" using the Graph API
Then the HTTP status code should be "200"
And user "Alice" should be able to send share invitation with all allowed permission roles
And user "Alice" should be able to send share the following invitation with all allowed permission roles
| resource | textfile.txt |
| space | new-space |
| sharee | Brian |
Expand Down Expand Up @@ -1313,4 +1313,4 @@ Feature: List a sharing permissions
}
}
}
"""
"""
4 changes: 2 additions & 2 deletions tests/acceptance/features/bootstrap/SharingNgContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ public function userShouldHaveSyncEnabledOrDisabledForShare(string $user, string
}

/**
* @Then user :user should be able to send share invitation with all allowed permission roles
* @Then user :user should be able to send share the following invitation with all allowed permission roles
*
* @param string $user
* @param TableNode $table
Expand All @@ -805,7 +805,7 @@ public function userShouldHaveSyncEnabledOrDisabledForShare(string $user, string
* @throws Exception
* @throws GuzzleException
*/
public function userShouldBeAbleToSendShareInvitationWithAllAllowedPermissionRoles(string $user, TableNode $table): void {
public function userShouldBeAbleToSendShareTheFollowingInvitationWithAllAllowedPermissionRoles(string $user, TableNode $table): void {
$listPermissionResponse = $this->featureContext->getJsonDecodedResponseBodyContent();
if (!isset($listPermissionResponse->{'@libre.graph.permissions.roles.allowedValues'})) {
Assert::fail(
Expand Down

0 comments on commit 1d5b771

Please sign in to comment.