Skip to content

Commit

Permalink
- OCCapabilities+PasswordPolicy: only generate rules for non-zero len…
Browse files Browse the repository at this point in the history
…gth requirements

- OCPasswordPolicyRuleByteLength: replace inaccurate message with accurate one
  • Loading branch information
felix-schwarz committed Mar 12, 2024
1 parent 4dbc4ad commit 3096454
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions ownCloudSDK/Password Policy/OCCapabilities+PasswordPolicy.m
Expand Up @@ -40,32 +40,32 @@ - (OCPasswordPolicy *)passwordPolicy
}

// Minimum and maximum length
if ((self.passwordPolicyMinCharacters != nil) ||
if (((self.passwordPolicyMinCharacters != nil) && (self.passwordPolicyMinCharacters.intValue > 0)) ||
(self.passwordPolicyMaxCharacters != nil))
{
[rules addObject:[OCPasswordPolicyRule characterCountMinimum:self.passwordPolicyMinCharacters maximum:self.passwordPolicyMaxCharacters]];
}

// Minimum lower-case characters
if (self.passwordPolicyMinLowerCaseCharacters != nil)
if ((self.passwordPolicyMinLowerCaseCharacters != nil) && (self.passwordPolicyMinLowerCaseCharacters.intValue > 0))
{
[rules addObject:[OCPasswordPolicyRule lowercaseCharactersMinimum:self.passwordPolicyMinLowerCaseCharacters maximum:nil]];
}

// Minimum upper-case characters
if (self.passwordPolicyMinUpperCaseCharacters != nil)
if ((self.passwordPolicyMinUpperCaseCharacters != nil) && (self.passwordPolicyMinUpperCaseCharacters.intValue > 0))
{
[rules addObject:[OCPasswordPolicyRule uppercaseCharactersMinimum:self.passwordPolicyMinUpperCaseCharacters maximum:nil]];
}

// Minimum digits
if (self.passwordPolicyMinDigits != nil)
if ((self.passwordPolicyMinDigits != nil) && (self.passwordPolicyMinDigits.intValue > 0))
{
[rules addObject:[OCPasswordPolicyRule digitsMinimum:self.passwordPolicyMinDigits maximum:nil]];
}

// Minimum special characters
if ((self.passwordPolicyMinSpecialCharacters != nil) && (self.passwordPolicySpecialCharacters != nil))
if ((self.passwordPolicyMinSpecialCharacters != nil) && (self.passwordPolicyMinSpecialCharacters.intValue > 0) && (self.passwordPolicySpecialCharacters != nil))
{
[rules addObject:[OCPasswordPolicyRule specialCharacters:self.passwordPolicySpecialCharacters minimum:self.passwordPolicyMinSpecialCharacters]];
}
Expand Down
Expand Up @@ -44,7 +44,7 @@ - (instancetype)initWithEncoding:(NSStringEncoding)encoding maximumByteLength:(N
_encoding = encoding;
_maximumByteLength = maximumByteLength;

self.localizedDescription = OCLocalizedFormat(@"Less than {{byteLength}} bytes.", @{ @"byteLength" : @(maximumByteLength).stringValue });
self.localizedDescription = OCLocalizedFormat(@"At most {{byteLength}} bytes.", @{ @"byteLength" : @(maximumByteLength).stringValue });
}

return (self);
Expand Down
2 changes: 1 addition & 1 deletion ownCloudSDK/Resources/de.lproj/Localizable.strings
Expand Up @@ -223,7 +223,7 @@
"At least {{min}} special characters: {{specialCharacters}}" = "Mindestens {{min}} Sonderzeichen: {{specialCharacters}}";

// OCPasswordPolicyRuleByteLength
"Less than {{byteLength}} bytes." = "Weniger als {{byteLength}} Bytes.";
"At most {{byteLength}} bytes." = "Maximal {{byteLength}} Bytes.";
"Password can't be converted to {{encoding}}." = "Passwort kann nicht als {{encoding}} kodiert werden.";
"Longer than {{byteLength}} bytes in {{encoding}} encoding." = "Länger als {{byteLength}} Bytes in {{encoding}} Encodierung.";

Expand Down
2 changes: 1 addition & 1 deletion ownCloudSDK/Resources/en.lproj/Localizable.strings
Expand Up @@ -223,7 +223,7 @@
"At least {{min}} special characters: {{specialCharacters}}" = "At least {{min}} special characters: {{specialCharacters}}";

// OCPasswordPolicyRuleByteLength
"Less than {{byteLength}} bytes." = "Less than {{byteLength}} bytes.";
"At most {{byteLength}} bytes." = "At most {{byteLength}} bytes.";
"Password can't be converted to {{encoding}}." = "Password can't be converted to {{encoding}}.";
"Longer than {{byteLength}} bytes in {{encoding}} encoding." = "Longer than {{byteLength}} bytes in {{encoding}} encoding.";

Expand Down

0 comments on commit 3096454

Please sign in to comment.