Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/add-demo-account] Add Account: Provide Demo Account Setup #826

Open
wants to merge 2 commits into
base: milestone/11.4.2
Choose a base branch
from

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Oct 28, 2020

Description

Added a new item Demo Account to the Add Account action which provides a preconfigured setup for the ownCloud demo server.
This item is only visible, if the server list is empty.
The branded login view will be used to add the demo account, which provides also further information for ownCloud and can be configured via the Branded.plist
On iOS 14 the new UIMenu will be used, on iOS 13 UIAlertViewController will be used instead to present the account items.

Related Issue

#512

Motivation and Context

There are also users, which are interested in ownCloud and which wants to test the ownCloud iOS app, but without having an own ownCloud instance.

How Has This Been Tested?

  • Tap on Add account, if the server list is empty
  • Select Demo Account
  • Follow the setup instructions
  • If a bookmarks was configured, the action Demo Account should no longer appear

Screenshots (if appropriate):

Simulator Screen Shot - iPhone 12 Pro Max - 2020-10-28 at 09 01 06 Simulator Screen Shot - iPhone 12 Pro Max - 2020-10-28 at 09 01 11
Simulator Screen Shot - iPhone 12 Pro Max - 2020-10-28 at 09 02 59 Simulator Screen Shot - iPhone 12 Pro Max - 2020-10-28 at 09 01 20

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hosy hosy added this to the 11.4.2-Current milestone Oct 28, 2020
@hosy hosy self-assigned this Oct 28, 2020
@hosy hosy requested review from jesmrec and mneuwert October 28, 2020 08:20

if #available(iOS 14.0, *), OCBookmarkManager.shared.bookmarks.count == 0 {
addServerBarButtonItem = UIBarButtonItem(systemItem: .add, primaryAction: nil, menu: createAddBookmarkMenu())
welcomeAddServerButton.menu = createAddBookmarkMenu()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hosy is menu support not available on iOS13?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for UIBarButtonItem and UIButton only for contextual menus

@hosy hosy modified the milestones: 11.4.2-Current, 11.5.0-Next Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the branch milestone/11.4.2 November 6, 2020 11:29
@michaelstingl michaelstingl modified the milestones: 11.5.0-Current, backlog Jan 13, 2021
@mneuwert
Copy link
Contributor

mneuwert commented Apr 5, 2021

@hosy @michaelstingl @jesmrec
Just as an idea: instead of always requiring two taps to create an account be could have a second button on this screen "Check out Demo" or something like that which directly would add and open demo account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants