Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[milestone/12.2] Milestone 12.2 #1327

Merged
merged 22 commits into from May 8, 2024
Merged

[milestone/12.2] Milestone 12.2 #1327

merged 22 commits into from May 8, 2024

Conversation

felix-schwarz
Copy link
Contributor

Description

Release 12.2 PR

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Added an issue with details about all relevant changes in the iOS documentation repository.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ felix-schwarz
You have signed the CLA already but the status is still pending? Let us recheck it.

felix-schwarz and others added 15 commits March 26, 2024 10:15
…1320)

* - update SDK to include OCItem.removed tracking fixes
- AccountControllerSearchViewController: new view controller for global search that's accessible from a new top-level sidebar item
- AppDelegate, CreateDocumentAction, OpenInWebAction: register settings for OpenInWeb and CreateDocument so they turn up in the auto-generated MDM docs
- OCSavedSearch: add support for copying
- AccountController.Configuration: remove showQuickAccess and add new variables for new top-level items
- SavedSearchCell: add support for new side button that allows setting an action (used for "Add to sidebar")
- OCSavedSearch+Interactions: add support for new "Quick Access" search suggestions in AccountControllerSearchViewController
- SearchViewController: allow customizing whether cancel buttons are shown or navigation buttons should be hidden
- ClientItemViewController: refactor search suggestions list to allow expansion/modification by subclasses

* - update SDK to include version tracking change for KVO data source
- OCSavedSearch: add uuid and name to .dataItemVersion
- OCVault+SavedSearches: add method updateSavedSearch for updating existing saved searches (f.ex. with a different name)
- AccountController:
	- rename searchesFolder to globalSearch to signal the new position in the sidebar
	- present saved searches directly in the top level of the sidebar
	- add useFolderForSearches var to allow switching between a flat or folder-based presentation of saved searches in the sidebar	- cleanup code
- AccountControllerSearchViewController: remove added quick access searches from quick access list, remove entire Quick Access section if all quick access searches were added
- SavedSearchCell: use gear-badged folder instead of gear icon for saved searches in the sidebar
- CollectionViewController: preserve selection after non-animated snapshot updates
- OCSavedSearch+Interactions: add "Rename" action to saved search context menu
- ClientItemViewController: fix warning

* - update SDK to fix table creation issue

* - update SDK
- ShareExtensionViewController: auto-open first account if only one account has been created
- OCSidebarItem: new class encapsulating custom user sidebar items, conforming to OCDataItem and OCDataItemVersioning
- OCVault+SidebarItems: add user side bar item management
- AccountController:
	- add saved searches and user sidebar items to configuration
	- add user sidebar items integration
- BrowserNavigationBookmark+AccountController: add support for sidebar items, refine representationSideBarItemRefs to return more (fallback) references
- Action: fix comment an identifier typos
- CollectionViewController:
	- add new method for retrieving the most specific client context for an index path
	- use new method to provide correct client context for allowDropOperation and performDropOperation
- OCLocation+Interactions: add new method for customized access to .openItem()
- OCSidebarItem+Cell: adds a cell provider for custom user sidebar items
- OCSidebarItem+Interactions: selection, swipe, context menu, drop and navigation restore support for OCSidebarItems
- BrowserNavigationBookmark: add sidebarItem property, including archiving/unarchiving

* - CollectionViewController/CollectionViewSection: add ability to add a per-section item for section fallback drop interaction handling

* - AddToSidebarAction:
	- only show action if item hasn't already been added to the sidebar
	- add custom icon with plus badge
- RemoveFromSidebarAction:
	- new action
	- only show action if item has already been added to the sidebar
	- add custom icon with minus badge

---------

Co-authored-by: felix-schwarz <felix-schwarz@users.noreply.github.com>
* - SDK update
- ShareViewController: add "generate" button to the password field that uses the password policy's generator to generate a password
- BottomButtonBar: add new alternative button to allow for an alternative main action; fix layout bug

* - SDK update: latest password policy progress and bug fixes
- PasswordComposerViewController:
	- new view controller to compose passwords
	- interactive feedback based on OCPasswordPolicy
	- integration with password generator based on OCPasswordPolicy
	- ability to copy passwords to clipboard
	- ability to show/hide entered passwords
	- support for editing and creation of password strings
- ShareViewController:
	- replace UIAlert with PasswordComposerViewController for entering passwords
	- add Generate button to generate a password based on the currently applicable password policy
	- add new "Share" button for links (in addition to "Create") that invoke the share sheet to directly share a link (including password) to the clipboard or directly to other apps like Mail or Messages
- add missing localizations
- BottomButtonBar: include alternativeButton in .modalActionRunning auto-enable/disable
- SegmentViewItem / SegmentViewItemView:
	- add extension to easily create button segments
	- add support for UIImage rendering modes for .icon
- ThemeCollection: add CSS entry for proper PasswordComposerViewController cell background coloring in dark mode

* - add line to copy the password to the clipboard (accidentally left out from previous commit)

* - update SDK to address findings
- PasswordComposerViewController: add notification upon copying password to clipboard

* Address findings (1) (2) (3) in #1325:
- ios-sdk:
	- add basic support for OC10 password policies
	- fix password generator error due to "empty" password policies derived from capabilities (finding 2)
- ShareViewController:
	- support for the requirement to set a password by disabling buttons and adding a warning triangle if no password is set (finding 1)
	- support for expiration date constraints:
		- support for the requirement by disabling buttons and adding a warning triangle if no date is set
		- add support for maximum date
		- add support for pre-setting an expiration date
	- add a "Copy" button next to the password if the password is known (finding 3)
	- clean up button creation code, avoiding duplication

* - ShareViewController: enforce password requirement even if files_sharing.public.password.enforced in capabilities is false, but the respectively matching files_sharing.public.password.enforced_for is true

---------

Co-authored-by: felix-schwarz <felix-schwarz@users.noreply.github.com>
@felix-schwarz felix-schwarz linked an issue Apr 22, 2024 that may be closed by this pull request
34 tasks
@felix-schwarz felix-schwarz removed a link to an issue Apr 22, 2024
34 tasks
felix-schwarz and others added 2 commits April 24, 2024 12:11
…targeting unavailable/detached drives and removes the respective policies (#1343)

- adapt app code to SDK API changes
* - upgrade OpenSSL from at least 1.1.180 to at least 3.1.5001 to include a privacy manifest
- add privacy manifest to all components
- update SDK to contain matching OpenSSL version

---------

Co-authored-by: felix-schwarz <felix-schwarz@users.noreply.github.com>
@felix-schwarz
Copy link
Contributor Author

@hosy @jesmrec Everything is merged into milestone/12.2 now. Please check and let me know once you have approved it. I can then (rebase) merge the changes into master and create a tag for the release.

@jesmrec jesmrec added the Approved by QA Approved by QA label Apr 25, 2024
@hosy
Copy link
Collaborator

hosy commented Apr 25, 2024

@jesmrec @felix-schwarz Before approving this PR: I think we should include the #1347 into this release.

@felix-schwarz
Copy link
Contributor Author

felix-schwarz commented Apr 25, 2024

@hosy Since this release already is delayed, I'd prefer to ship 12.2 now - and include #1347 either in a quick, subsequent 12.2.1 or 12.3 as soon as it has passed QA.

Otherwise, we'd need to wait for QA of #1347 and then go through QA for the merged result again, delaying the release further.

@hosy hosy merged commit b3009fa into master May 8, 2024
6 of 7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the milestone/12.2 branch May 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants