Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] 11.2.1.1 Keyboard #1336

Open
7 tasks done
tschiebel opened this issue Apr 5, 2024 · 2 comments · May be fixed by #1349
Open
7 tasks done

[a11y] 11.2.1.1 Keyboard #1336

tschiebel opened this issue Apr 5, 2024 · 2 comments · May be fixed by #1349
Assignees
@felix-schwarz
Labels
Accessibility bug Something isn't working p3-medium Normal priority
Milestone
12.3-Next

Comments

@tschiebel
Copy link

tschiebel commented Apr 5, 2024 •
edited by felix-schwarz

audit: https://infinite.owncloud.com/s/qSvYucPltEYUhhc

https://github.com/BIK-BITV/BIK-App-Test/tree/main/Pr%C3%BCfschritte/de
https://www.etsi.org/deliver/etsi_en/301500_301599/301549/03.02.01_60/en_301549v030201p.pdf

Personal Space

  • In the test, it was not possible to focus the sort button with the keyboard.
    focus with the keyboard.
    image

Fix: the sort button can now be reached through Tab and Shift + Tab.

  • It is not possible to focus the "More" buttons using the keyboard.
    image

Fix: the more button can either be triggered by pressing the Return key, or by using the system-provided Tab + Z menu when the row is focused

Menu

  • The "Eject" button cannot be focused using the keyboard.
    image

Fix: the eject action is now available through the system-provided Tab + Z menu

Shared with me

  • It is not possible to use the keyboard to focus the "More" buttons.
    image

Fix: the more button can either be triggered by pressing the Return key, or by using the system-provided Tab + Z menu when the row is focused

  • It is not possible to use the keyboard to focus the "Accept" and "Reject" buttons.
    "Reject" buttons with the keyboard.

Fix: the Accept and Reject actions can now be reached using the system-provided Tab + Z menu when the row is focused

Shared with others

  • The buttons with the arrow pointing to the right cannot be focused and activated using the keyboard.
    and activated with the keyboard. Instead, the entire list element is focused, but it
    cannot be activated.
    image

Fix: the reveal button can either be triggered by pressing the right arrow key, or by using the system-provided Tab + Z menu when the row is focused

Image Viewer

  • It is not possible to change the elements of the carousel using the keyboard.
    using the keyboard. It is only possible using swipe gestures.

Fix:: the elements of the carousel can now be navigated with Shift + CursorLeft and Shift + CursorRight when the carousel is focused
@tschiebel tschiebel added bug Something isn't working p3-medium Normal priority Accessibility labels Apr 5, 2024
@felix-schwarz felix-schwarz self-assigned this May 17, 2024
@felix-schwarz
Copy link
Contributor

Useful resources debugging and fixing this:

felix-schwarz added a commit that referenced this issue May 17, 2024
@felix-schwarz
- ownCloud.xcscheme: make focus debugging options available
0f69275 
- Localizable.strings: add missing key and translation for sort bar item to toggle layout
- SortBar: make sort mode and multiselection buttons accessible by keyboard navigation (via tab and shift-tab), resolving the top issue of #1336
- ViewCell: pass through accessibilityRespondsToUserInteraction from hosted view, allowing to opt out of keyboard navigation
- ClientItemViewController: opt out statistics footer from keyboard navigation
- ClientLocationBarController, OCLocation+Breadcrumbs: make keyboard navigatable
- SegmentViewItem: add support for isAccessibilityElement and accessibilityTraits
felix-schwarz added a commit that referenced this issue May 17, 2024
@felix-schwarz
- ownCloud.xcscheme: make focus debugging options available
c94c953 
- Localizable.strings: add missing key and translation for sort bar item to toggle layout
- SortBar: make sort mode and multiselection buttons accessible by keyboard navigation (via tab and shift-tab), resolving the top issue of #1336
- ViewCell: pass through accessibilityRespondsToUserInteraction from hosted view, allowing to opt out of keyboard navigation
- ClientItemViewController: opt out statistics footer from keyboard navigation
- ClientLocationBarController, OCLocation+Breadcrumbs: make keyboard navigatable
- SegmentViewItem: add support for isAccessibilityElement and accessibilityTraits
@felix-schwarz felix-schwarz linked a pull request May 17, 2024 that will close this issue
Open
3 tasks
@felix-schwarz
Copy link
Contributor

felix-schwarz commented May 17, 2024 •
edited

Keyboard navigation is structurally not well-prepared for reaching additional actions in rows like "Reveal" and "More". That functionality is therefore made available via Accessibility Custom Actions, reachable via Tab + Z while the respective element is focused.

@TheOneRing TheOneRing added this to the 12.3-Next milestone May 21, 2024
felix-schwarz added a commit that referenced this issue May 22, 2024
@felix-schwarz
- ActionCell: direct keyboard focus to embedded buttons, allowing to …
d3cd5d4 
…reach them via the keyboard (similar to issue in #1336)

- DriveHeaderCell: replace hardcoded background color for darkBackgroundView with new "semicover" CSS selector and ThemeCSSView
- DriveGridCell: dynamically change CSS selectors based on focused state and trigger color updates (enabling fix for #1338)
- SavedSearchCell: make side button actions (typically "Add to sidebar") accessible as custom accessibility action
- UniversalItemListCell: reflect .isFocused state changes in the CSS selectors of the primary and secondary detail views
- ComposedMessageView: opt-out of keyboard focus (see #1337)
- OCAction+UIAction: add method to derive a UIAccessibilityCustomAction from an OCAction
- SegmentView: re-create and layout item views if CSS selectors change
- ThemeCSS: add new .focused selector
- ThemeCollection: add new records for focused state of UniversalItemListCell (to fix contrast of secondary line, see #1338) and drive grid cell (to clearly distinguish focused and unfocused states, see #1338)
@felix-schwarz felix-schwarz linked a pull request May 23, 2024 that will close this issue
[fix/a11y] Fix accessibility issues #1349
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felix-schwarz felix-schwarz

Labels
Accessibility bug Something isn't working p3-medium Normal priority
Projects
None yet
Milestone
12.3-Next
Development

Successfully merging a pull request may close this issue.

[fix/a11y] Fix accessibility issues owncloud/ios-app
3 participants
@TheOneRing @felix-schwarz @tschiebel