Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rector #41041

Closed
wants to merge 2 commits into from
Closed

feat: add rector #41041

wants to merge 2 commits into from

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Oct 11, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sfadschm
Copy link

Will rector then also be used to perform the php 8.2 upgrade?

@DeepDiver1975
Copy link
Member Author

Php 8.2 is already in here #40981

This PR is an experiment..... Let's see....

@sfadschm
Copy link

Fingers crossed!

From my experience, rector is a valuable tool and might ease the php upgrade significantly.

But I see you are right, a lot of work towards 8.2 has already been done.

Btw: Thanks for all the work!

@DeepDiver1975
Copy link
Member Author

conflicting meanwhile ...... 🤷

@DeepDiver1975 DeepDiver1975 deleted the feat/rector branch November 23, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants