Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jasmine-core from 2.99.1 to 5.1.1 in /build #40956

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 28, 2023

Bumps jasmine-core from 2.99.1 to 5.1.1.

Release notes

Sourced from jasmine-core's releases.

5.1.1

Please see the release notes.

5.1.0

Please see the release notes.

5.0.1

Please see the release notes.

5.0.0

Please see the release notes.

5.0.0-beta.0

Please see the release notes.

5.0.0-alpha.1

Please see the release notes.

5.0.0-alpha.0

Please see the release notes.

4.6.0

Please see the release notes.

4.5.0

Please see the release notes.

4.4.0

Please see the release notes.

4.3.0

Please see the release notes.

4.2.0

Please see the release notes.

4.1.1

Please see the release notes.

4.1.0

Please see the release notes.

4.0.1

Please see the release notes.

4.0.0

Please see the release notes.

3.99.1

Please see the release notes.

... (truncated)

Commits
  • bff612a Bump version to 5.1.1
  • 4ba42f3 Fixed global variable leak when using ParallelReportDispatcher
  • 58bee05 Documented usage of eval in DelayedFunctionScheduler
  • c1871b0 Removed unnecessary throw when building stack trace
  • c16974b Improved jsdocs for originalFn argument to createSpy
  • bfedda9 Link to 5.0 upgrade guide in README, not 4.0
  • a67b727 Fixed jsdocs for throwUnless and throwUnlessAsync
  • 47f3105 Bump version to 5.1.0
  • aeb5653 Built distribution
  • 75d45ef Exclude inherited Error properties from stack trace
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by sgravrock, a new releaser for jasmine-core since your current version.


Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@update-docs
Copy link

update-docs bot commented Aug 28, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/build/jasmine-core-5.1.1 branch from 1f3e486 to bb8060e Compare October 9, 2023 09:20
@phil-davis
Copy link
Contributor

https://github.com/dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/build/jasmine-core-5.1.1 branch from bb8060e to 3d42ba7 Compare October 10, 2023 00:56
@phil-davis
Copy link
Contributor

All the webUI acceptance tests pass, so there is not anything "basic" wrong with the classic web user interface.

https://drone.owncloud.com/owncloud/core/39284/7/5
Only the JavaScript test pipeline fails.

TypeError: oc_appconfig.files is undefined in apps/files/js/filelockplugin.js (line 29)
  _extendFileActions@apps/files/js/filelockplugin.js:154:8 <- apps/files/js/filelockplugin.js:29:1058
  attach@apps/files/js/filelockplugin.js:81:9 <- apps/files/js/filelockplugin.js:26:84
  attach@core/js/js.js:933:12 <- core/js/js.js:307:458
  initialize@apps/files/js/filelist.js:375:15 <- apps/files/js/filelist.js:125:577
  FileList@apps/files/js/filelist.js:37:8 <- apps/files/js/filelist.js:27:114
  initialize@apps/files/js/app.js:82:20 <- apps/files/js/app.js:34:40
  @apps/files/js/app.js:321:17 <- apps/files/js/app.js:86:84
  delay</<@core/vendor/underscore/underscore.js:1086:19

@phil-davis
Copy link
Contributor

@DeepDiver1975 this jumps a few major versions. I suppose that there will be a lot of backward-compatibility issues that need fixing. For example:
https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-how-specs-are-written
There is mention of beforeEach and beforeAll and that the error detection is improved. I suppose that is why the "oc_appconfig.files is undefined" happens now - filelockpluginSpec.js beforeEach has an attempt a setting oc_appconfig but my IDE complains about it.

Is someone going to look at this stuff? I am not really a JS guy ;)

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 12, 2024

A newer version of jasmine-core exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@phil-davis phil-davis force-pushed the dependabot/npm_and_yarn/build/jasmine-core-5.1.1 branch from cf22336 to cfee958 Compare February 13, 2024 04:00
@phil-davis
Copy link
Contributor

I manually rebased and force pushed. We can see what fresh CI thinks...

dependabot bot and others added 2 commits February 13, 2024 10:20
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 2.99.1 to 5.1.1.
- [Release notes](https://github.com/jasmine/jasmine/releases)
- [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md)
- [Commits](jasmine/jasmine@v2.99.1...v5.1.1)

---
updated-dependencies:
- dependency-name: jasmine-core
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@phil-davis phil-davis force-pushed the dependabot/npm_and_yarn/build/jasmine-core-5.1.1 branch from c1b1f4f to 68df459 Compare February 13, 2024 04:35
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/39729/8/5

Firefox 121.0 (Ubuntu 0.0.0) OCA.Sharing.Util tests public link quick action copies the quick link to clipboard FAILED
	TypeError: jasmine.pp is not a function in build/node_modules/jasmine-sinon/lib/jasmine-sinon.js (line 46)
	otherArgs@build/node_modules/jasmine-sinon/lib/jasmine-sinon.js:46:24
	spyWithOtherArgs/<@build/node_modules/jasmine-sinon/lib/jasmine-sinon.js:27:24
	compare@build/node_modules/jasmine-sinon/lib/jasmine-sinon.js:198:30
	<Jasmine>
	@apps/files_sharing/tests/js/shareSpec.js:660:29
	<Jasmine>
.......................................
Firefox 121.0 (Ubuntu 0.0.0): Executed 1044 of 1046 (1 FAILED) (skipped 2) (12.313 secs / 11.518 secs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants