Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Use of publicWebDAVAPIVersion on publicLocksFileLastSharedFolder function #40883

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

KarunAtreya
Copy link
Contributor

Description

This PR make the use of publicWebDAVAPIVersion on publicLocksFileLastSharedFolder function as mentioned in #40756
As the changes was made the response code was different for new webdav api path. So new issue was created #40882
So, this pr also has bug demonstration for it.

Related Issue

#40756

Motivation and Context

make the use of publicWebDAVAPIVersion on publicLocksFileLastSharedFolder function

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SagarGi SagarGi requested a review from grgprarup July 19, 2023 03:43
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 9fef0fc into master Jul 19, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor-public-lock-lastshared-folder branch July 19, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants