Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [10.11.0] Allow editing of public link shared single files 10.11 #40333

Conversation

phil-davis
Copy link
Contributor

Description

This is the same as #40317 but targeted at release-10.11.0 branch.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from ownclouders Sep 5, 2022
Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, has all the 6 comits of original 40317.

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mrow4a
Copy link
Contributor

mrow4a commented Sep 5, 2022

@phil-davis @pmaier1 to decide whether some minor fixes are needed to be backported from #40289 in a commit here, or we also add into 10.11 release #40289 that contains new feature and a fix to the one from this PR

@mrow4a
Copy link
Contributor

mrow4a commented Sep 5, 2022

@phil-davis backported changed from https://github.com/owncloud/core/pull/40289/files in the commit here 96c704c

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIWebdavLockProt-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/36755/160

@phil-davis phil-davis changed the title [10.11.0] Allow editing of public link shared single files 10.11 [full-ci] [10.11.0] Allow editing of public link shared single files 10.11 Sep 6, 2022
@phil-davis phil-davis force-pushed the allow-editing-of-public-link-shared-single-files-10.11 branch 2 times, most recently from 0c12598 to 897b29d Compare September 6, 2022 08:06
@CLAassistant
Copy link

CLAassistant commented Sep 6, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 9 committers have signed the CLA.

✅ ScharfViktor
✅ SwikritiT
✅ mmattel
✅ SagarGi
✅ kiranadh1452
✅ DeepDiver1975
✅ phil-davis
✅ mrow4a
❌ ownclouders
You have signed the CLA already but the status is still pending? Let us recheck it.

@phil-davis phil-davis force-pushed the allow-editing-of-public-link-shared-single-files-10.11 branch from 897b29d to f014b47 Compare September 6, 2022 08:06
@phil-davis
Copy link
Contributor Author

I made a mess of rebasing, accidentally!!! I will try to fix it soon, but I need to go to the airport now. Sorry.

@phil-davis
Copy link
Contributor Author

phil-davis commented Sep 6, 2022

See #40342

@jnweiger jnweiger self-requested a review September 6, 2022 09:48
Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superceeded by #40342

@phil-davis phil-davis closed this Sep 6, 2022
@phil-davis phil-davis deleted the allow-editing-of-public-link-shared-single-files-10.11 branch September 6, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet