Spelling #9044

jsoref · 2021-09-17T08:50:39Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@d234b5c#commitcomment-56639815

The action reports that the changes in this PR would make it happy: jsoref@dc7338c

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

CLAassistant · 2021-09-17T08:50:47Z

All committers have signed the CLA.

TheOneRing · 2021-09-17T08:58:17Z

Woa sounds great and I'd love a spell checker action.
I will need some time to check those.
Note: Some of the files where auto generated to fixing the spelling in the changelog.md for example doesn't make much sense.
I also saw some unrelated code style changes?

jsoref

This correction pass was almost entirely made by Google Sheets.

I sometimes look for non-existent variants and similar, but didn't here.

I'm happy to make fixes (but probably won't have time for a while).

CHANGELOG.md

jsoref · 2021-09-17T08:53:03Z

shell_integration/icons/nopadding/SVG/generate_windows_ico.sh

-# Dimensions taken from https://www.apriorit.com/dev-blog/357-shell-extentions-basics-samples-common-problems#_Toc408244375
+# Dimensions taken from https://www.apriorit.com/dev-blog/357-shell-extensions-basics-samples-common-problems#_Toc408244375


Both urls work as does https://www.apriorit.com/dev-blog/357-foo

jsoref · 2021-09-17T08:54:22Z

src/common/syncjournaldb.cpp

+#include <QDir>
+#include <QElapsedTimer>
 #include <QFile>
 #include <QLoggingCategory>
 #include <QStringList>
-#include <QElapsedTimer>
 #include <QUrl>
-#include <QDir>
-#include <sqlite3.h>
 #include <cstring>
+#include <sqlite3.h>


This reordering is done in a distinct commit before my work because my work tripped on a linter. I think that I've included enough to prevent this from happening to the next hapless contributor, but I'd encourage someone to check.

@TheOneRing re #9044 (comment) this is:
jsoref@51b6bb7

I'd encourage you to merge that commit outside of this PR, since it really doesn't belong, but the linter failed and it was way too messy for me to handle it any other way here. -- And the only way to show it mattered was to compose this PR.

jsoref · 2021-09-17T08:55:24Z

src/common/syncjournaldb.cpp

@@ -831,7 +833,7 @@ bool SyncJournalDb::updateErrorBlacklistTableStructure()
    SqlQuery query(_db);
    query.prepare("CREATE INDEX IF NOT EXISTS blacklist_index ON blacklist(path collate nocase);");
    if (!query.exec()) {
-        sqlFail(QStringLiteral("updateErrorBlacklistTableStructure: create index blacklit"), query);
+        sqlFail(QStringLiteral("updateErrorBlacklistTableStructure: create index blacklist"), query);


Note: I'm only running a spell checker. Modern practices discourage the use of this term entirely, and that's far beyond the scope of this PR.

(If you adopt a spell checker, you could add this word to a reject list to prevent people from using it going forward...)

jsoref · 2021-09-17T08:56:26Z

src/common/syncjournaldb.h

@@ -213,11 +213,11 @@ class OCSYNC_EXPORT SyncJournalDb : public QObject
     * This usually creates some temporary files next to the db file, like
     * $dbfile-shm or $dbfile-wal.
     *
-     * returns true if it could be openend or is currently opened.
+     * returns true if it could be opened or is currently opened.


This is a purely spell-checking oriented PR. Grammatically, I'd probably write is currently or could be opened.

jsoref · 2021-09-17T09:06:06Z

test/testallfilesdeleted.cpp

@@ -252,7 +252,7 @@ private slots:
        QVERIFY(fakeFolder.syncOnce());
        QCOMPARE(fingerprintRequests, 2);
        auto currentState = fakeFolder.currentLocalState();
-        // Altough the local file is kept as a conflict, the server file is downloaded
+        // Although the local file is kept as a conflict, the server file is downloaded


jsoref · 2021-09-17T09:06:16Z

test/testallfilesdeleted.cpp


        QVERIFY(fakeFolder.syncOnce());
-        QCOMPARE(fakeFolder.currentLocalState(), FileInfo{}); // all files should be one localy
+        QCOMPARE(fakeFolder.currentLocalState(), FileInfo {}); // all files should be one locally


test/testcookies.cpp

jsoref · 2021-09-17T09:07:29Z

test/testdownload.cpp

-    void serverMaintenence() {
+    void serverMaintenance()


serverMaintenance

test/testexcludedfiles.cpp

jsoref · 2021-09-17T09:18:47Z

Fwiw, this is what I used to ignore files:
https://github.com/jsoref/owncloud-client/blob/spell-check/.github/actions/spelling/excludes.txt

Files that were ignored weren't checked for typos, and as long as I didn't make any mistakes, ignored files weren't changed either (beyond the linter changes which are really an entirely unrelated kettle of fish).

I specifically ignored ^changelog/[^/]*_ for this repository (but not some of the others), this may have been the wrong choice. It isn't terribly hard for me to unignore items, either. The spell checker uses fairly naive heuristics to suggest exclusions, and I generalize based on my experience w/ things, but I'm human and the spell-checker was written by me, so both stages can make mistakes.

If you can identify other files you don't want changed, it's trivial for me to add them to excludes and to drop their changes from this PR (or its relatives for the other owncloud repositories).

If there's an upstream for typos, feel free to identify them, I have an imaginary queue of things to check, and will happily add items to the queue, although I make no promises about when i'll get to items in it 😺.

ownclouders · 2022-03-27T22:05:14Z

Results for GUI-tests https://drone.owncloud.com/owncloud/client/11261/5/1
💥 The GUI tests failed.
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/11261/guiReportUpload/index.html)
Server Logs: (https://cache.owncloud.com/public/owncloud/client/11261/guiReportUpload/serverlog.log)

jsoref

At the risk of losing GitHub's fancy review features, you can use:
6cf9783...4a818de to confirm that the only commit that's changing style is 6cf9783 -- it's necessary because the linter screams at me if I don't do it (as noted earlier).

Note: the repository has lots of files that would fail the linter, it's really an obstacle for drive-by-contributions. If this were my project, I'd apply the linter to all files at once so that any new change wouldn't be forced to deal w/ files that aren't linter-stable.

jsoref · 2022-03-27T21:58:52Z

changelog/unreleased/9236

-Bugfix: Client warns about non exisitng files
+Bugfix: Client warns about nonexistent files


This is listed as unreleased, does that mean I can still change it? Or should I exclude this folder as well?

jsoref · 2022-03-27T21:59:12Z

src/csync/ChangeLog

-version 0.91.4  (released 2013-12-12, ownCloud Cleint 1.5.0)
+version 0.91.4  (released 2013-12-12, ownCloud Client 1.5.0)


Should I exclude this file / this folder?

jsoref · 2022-03-27T22:00:13Z

resources/font-awesome/update_color.ps1

-    Write-Host "update_corlor.ps1 `"#B5B6BB`""
+    Write-Host "update_color.ps1 `"#B5B6BB`""


This makes the output match the filename...

jsoref · 2022-03-27T22:01:32Z

test/testsyncvirtualfiles.cpp

-        // If the local virtual file file is removed, it'll just be recreated
+        // If the local virtual file is removed, it'll just be recreated


I've recently added some code to detect word duplication. I can certainly suppress it if it's annoying, but on average it's pretty accurate (and a handful of additional patterns are sufficient to cover the edge cases where it's wrong).

jsoref · 2022-03-27T22:02:26Z

test/testpermissions.cpp

-        rm.insert("changeonly/sub1/filetorname1a");
-        rm.insert("changeonly/sub1/filetorname1z");
+        rm.insert("changeonly/sub1/filetorename1a");
+        rm.insert("changeonly/sub1/filetorename1z");


I didn't see any particular reason to omit the e from rename

jsoref · 2022-03-27T22:03:53Z

test/testallfilesdeleted.cpp

-    void testDataFingetPrint_data()
+    void testDataFingerPrint_data()


jsoref · 2022-03-27T22:04:24Z

test/gui/tst_checkAlltabs/test.feature

@@ -2,7 +2,7 @@ Feature: Visually check all tabs

    As a user
    I want to visually check all tabs in client
-    So that I can performe all the actions related to client
+    So that I can perform all the actions related to client


    Scenario: Tabs in toolbar looks correct


The folder below is gaining an e in delete:

jsoref · 2022-03-27T22:04:51Z

test/gui/suite.conf

-TEST_CASES=tst_addAccount tst_sharing tst_syncing tst_loginLogout tst_removeAccountConnection tst_checkAlltabs tst_vfs tst_deletFilesFolders tst_editFiles
+TEST_CASES=tst_addAccount tst_sharing tst_syncing tst_loginLogout tst_removeAccountConnection tst_checkAlltabs tst_vfs tst_deleteFilesFolders tst_editFiles


The test case is gaining an e in delete (see renames below)

jsoref · 2022-03-27T22:05:22Z

src/libsync/theme.h

-     * reimplementable for legacy reasons.
+     * overridable for legacy reasons.


jsoref · 2022-03-27T22:11:13Z

shell_integration/windows/OCOverlays/OCOverlay.cpp

-    // this defines which handler has prededence, so
-    // we order this in terms of likelyhood
+    // this defines which handler has precedence, so
+    // we order this in terms of likelihood
    switch (_state) {
    case State_OK:
        *pPriority = 0; break;


The below file is being renamed from deprACtion to depreCAtion:

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

ownclouders · 2022-05-12T06:15:04Z

Results for GUI-tests https://drone.owncloud.com/owncloud/client/11728/6/1

💥 The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/11728/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/11728/guiReportUpload/serverlog.log

Screenshots:

jsoref commented Sep 17, 2021

View reviewed changes

github-actions bot added the Stale label Mar 20, 2022

github-actions bot closed this Mar 27, 2022

TheOneRing removed the Stale label Mar 27, 2022

TheOneRing reopened this Mar 27, 2022

jsoref force-pushed the spelling branch 2 times, most recently from f4abd2c to 4a818de Compare March 27, 2022 21:56

jsoref commented Mar 27, 2022

View reviewed changes

github-actions bot added the Stale label Apr 27, 2022

github-actions bot closed this May 5, 2022

TheOneRing reopened this May 5, 2022

TheOneRing removed the Stale label May 5, 2022

TheOneRing added this to the 2.12 milestone May 5, 2022

jsoref added 13 commits May 12, 2022 00:44

Run owncloud-ci/git-clang-format-lint@master

0090b2f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: accessed

08d1322

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: acquire

46f28aa

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: activity

93e5cb9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: actual

aba16cf

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: algorithm

d9c0dc6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: alphabetically

fa21e8c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: although

c6c9052

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: and

bde98a8

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: announce

0c45839

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: another

58620af

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: appearances

9ddf7df

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: assigned

73263a5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 27 commits May 12, 2022 00:47

spelling: remaining

30dc1b0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: repositories

4615d6c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: retrieve

655bff2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: retrieved

0d786b2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: returns

f5296ef

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: separate

9e0d32c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: separator

9fdc46e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: setups

50fcc57

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: several

592cb7c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: sibling

6b4e2c1

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: similarly

2ce88b3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: something

b58cccc

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: successful

39c1945

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: suddenly

014f69e

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: symmetric

42d8f08

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: symmetry

35cfb78

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: that

59b7cab

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: the

e5c959f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: their

cc6fc0b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: tracker

d73ae05

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: transferred

51fe990

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: truncate

88db0e6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: upscaling

6fb88e7

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: useful

6d43b56

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: variable

abd39ee

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: whether

f817670

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: written

74cbfe9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from 4a818de to 74cbfe9 Compare May 12, 2022 04:47

TheOneRing removed this from the Desktop Client 4.0 milestone Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #9044

Spelling #9044

jsoref commented Sep 17, 2021

CLAassistant commented Sep 17, 2021 •

edited

TheOneRing commented Sep 17, 2021

jsoref left a comment

jsoref Sep 17, 2021

jsoref Sep 17, 2021

jsoref Sep 17, 2021

jsoref Sep 17, 2021

jsoref Sep 17, 2021

jsoref Sep 17, 2021

jsoref Sep 17, 2021

jsoref Sep 17, 2021

jsoref commented Sep 17, 2021

ownclouders commented Mar 27, 2022

jsoref left a comment

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

jsoref Mar 27, 2022

ownclouders commented May 12, 2022

		# Dimensions taken from https://www.apriorit.com/dev-blog/357-shell-extentions-basics-samples-common-problems#_Toc408244375
		# Dimensions taken from https://www.apriorit.com/dev-blog/357-shell-extensions-basics-samples-common-problems#_Toc408244375

		Bugfix: Client warns about non exisitng files
		Bugfix: Client warns about nonexistent files

		version 0.91.4 (released 2013-12-12, ownCloud Cleint 1.5.0)
		version 0.91.4 (released 2013-12-12, ownCloud Client 1.5.0)

		Write-Host "update_corlor.ps1 `"#B5B6BB`""
		Write-Host "update_color.ps1 `"#B5B6BB`""

		// If the local virtual file file is removed, it'll just be recreated
		// If the local virtual file is removed, it'll just be recreated

		void testDataFingetPrint_data()
		void testDataFingerPrint_data()

		TEST_CASES=tst_addAccount tst_sharing tst_syncing tst_loginLogout tst_removeAccountConnection tst_checkAlltabs tst_vfs tst_deletFilesFolders tst_editFiles
		TEST_CASES=tst_addAccount tst_sharing tst_syncing tst_loginLogout tst_removeAccountConnection tst_checkAlltabs tst_vfs tst_deleteFilesFolders tst_editFiles

		* reimplementable for legacy reasons.
		* overridable for legacy reasons.

Spelling #9044

Are you sure you want to change the base?

Spelling #9044

Conversation

jsoref commented Sep 17, 2021

CLAassistant commented Sep 17, 2021 • edited

TheOneRing commented Sep 17, 2021

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsoref commented Sep 17, 2021

ownclouders commented Mar 27, 2022

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ownclouders commented May 12, 2022

CLAassistant commented Sep 17, 2021 •

edited