Port LoginRequiredDialog to an AccountModalWidget
#11614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And thereby not embed a complete `QDialog` in the settings window. Fixes: #11592
|
No time has been spend yet on the look, so the "new" look for now is: 
|
|
How about this: 
|
TheOneRing
reviewed
Apr 24, 2024
src/gui/accountmodalwidget.h
Outdated
| @@ -27,10 +28,19 @@ class AccountModalWidget : public QWidget | |||
| public: | |||
| AccountModalWidget(const QString &title, QWidget *widget, QWidget *parent); | |||
|
|
|||
| enum DialogCode { Rejected, Accepted }; | |||
There was a problem hiding this comment.
enum class. and q_emum please.
Would Result be a better name?
|
Wizard with basic auth 
|
TheOneRing
requested changes
Apr 24, 2024
erikjv
force-pushed
the
work/port-LoginRequiredDialog
branch
from
59dcb89
to
73f38e9
Compare
TheOneRing
approved these changes
May 8, 2024
The share dialog and the folder wizard still use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And thereby not embed a complete
QDialogin the settings window.Fixes: #11592