Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RemoveAllFiles dialog #11545

Closed
wants to merge 2 commits into from
Closed

Update RemoveAllFiles dialog #11545

wants to merge 2 commits into from

Conversation

TheOneRing
Copy link
Member

@TheOneRing TheOneRing commented Mar 15, 2024

Goal of this change is to prepare the removal of addModalLegacyDialog

Please also have a look on #11564 where a qml is used instead

image

Old:
image

@TheOneRing TheOneRing changed the title Dialogs Update RemoveAllFiles dialog Mar 26, 2024
@TheOneRing TheOneRing marked this pull request as ready for review March 26, 2024 13:00
@TheOneRing
Copy link
Member Author

@tbsbdr for the design I tried to use the available space better.

@tbsbdr
Copy link

tbsbdr commented Mar 27, 2024

I'd remove the dialog at all.
if all files got deleted from the server, the default should be that all files get also deleted from the client. the server is the source of truth; files can be restored from the server trashbin if this was done unintentionally.

@TheOneRing TheOneRing closed this Apr 3, 2024
@TheOneRing TheOneRing deleted the work/dialogs branch April 3, 2024 09:44
@erikjv erikjv restored the work/dialogs branch April 29, 2024 14:03
@erikjv erikjv deleted the work/dialogs branch April 29, 2024 14:04
@erikjv erikjv restored the work/dialogs branch April 30, 2024 13:54
@erikjv erikjv deleted the work/dialogs branch May 2, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants