Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port LoginRequiredDialog from a QDialog to an AccountModalWidget #11592

Open
TheOneRing opened this issue Apr 9, 2024 · 1 comment · May be fixed by #11614
Open

Port LoginRequiredDialog from a QDialog to an AccountModalWidget #11592

TheOneRing opened this issue Apr 9, 2024 · 1 comment · May be fixed by #11614
Assignees
@erikjv
Milestone
Desktop 6.0

Comments

@TheOneRing
Copy link
Member

LoginRequiredDialog is still a real QDialog that is now used as a widget in an account modal view.
It should be adopted to the new aspect ratio and better use the visual space in the account page.
@TheOneRing TheOneRing added this to the Desktop 6.0 milestone Apr 9, 2024
@erikjv erikjv changed the title Port LoginRequiredDialog from a QDIalog to an AccountModalWidget Port LoginRequiredDialog from a QDialog to an AccountModalWidget Apr 16, 2024
@erikjv erikjv self-assigned this Apr 16, 2024
@erikjv
Copy link
Contributor

erikjv commented Apr 18, 2024

Screenshot 2024-04-18 at 16 22 10

Current/old "dialog"

erikjv added a commit that referenced this issue Apr 23, 2024
@erikjv
Port LoginRequiredDialog to an AccountModalWidget
8fe2be4 
And thereby not embed a complete `QDialog` in the settings window.

Fixes: #11592
@erikjv erikjv linked a pull request Apr 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
None yet
Projects
None yet
Milestone
Desktop 6.0
Development

Successfully merging a pull request may close this issue.

Port LoginRequiredDialog to an AccountModalWidget owncloud/client
2 participants
@erikjv @TheOneRing