Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Adding rpy2 (and R and deseq2) as test-only dependency.ies to have more flexible end2end tests #190

Open
jeandut opened this issue Oct 19, 2023 · 0 comments

Comments

@jeandut
Copy link
Contributor

jeandut commented Oct 19, 2023

Is your feature request related to a problem? Please describe.
As of now comparison between pydeseq2 and deseq2 necessitates to run deseq2 in R/r2py then save results in csvs in repository to later compare pydeseq2 back to it. This prevents flexibly testing different use-cases using parametrized tests varying i.e. design factors or read-counts values.
For instance to test PR #181 one would have wanted to do something around the lines of:

import pytest
import rpy2

@pytest.mark.parametrize("design_factors, continuous_factors", [(["a", "a:b"], "a"), ("~ a + b + a:b", "c"), (["a:b:c", b"], None, (["a:b:c", b"],["a","b","c"])
def test_matching_deseq2(design_factors, continuous_factors):
    # Run deseq2 and pydeseq2 on the current design_factors, continuous_factors pair
    assert pydeseq2_result == deseq2_result

Describe the solution you'd like
Adding rpy2 as a test-only dependency + installing R/deseq2 in the CI/tests should allow to run tests more flexibly and should keep regular install of pydeseq2 as lightweight as before.

What do you think @BorisMuzellec @mandreux-owkin @maikia ?

@jeandut jeandut changed the title [RFC] Adding r2py as test-only dependency to have more flexible end2end tests [RFC] Adding r2py (and R and deseq2) as test-only dependency.ies to have more flexible end2end tests Oct 20, 2023
@jeandut jeandut changed the title [RFC] Adding r2py (and R and deseq2) as test-only dependency.ies to have more flexible end2end tests [RFC] Adding rpy2 (and R and deseq2) as test-only dependency.ies to have more flexible end2end tests Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant