[web] Fix hardcode 'You' with i18 translation (also add locale for moment js) #1214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello, I am Musicminion, Overleaf’s volunteer translator for Chinese. When I was using and translating Overleaf I found that the project owner in your Project page was not translated. So I checked related code, it seems that phrase
You
is hard coded, as shown in the pic.I am not sure if this is by design, so I make a pr. And I have signed contributor Agreement with name Musicminion.
In the meantime, it seems that you use moment.js to show time, however, you didn't set locale for moment.js, so, as shown above, the relative modify time is also untranslated in English.
I try to add locale setting for moment.js with the following code, but this commit is not contained in this pr, if you are interested, I can add this commit too!
After fix, the effect is shown below, it can show the relative time correctly.
I have run image build for this pr with my own server, it works well too.
Thanks for your time of this pr!
Related issues / Pull Requests
Contributor Agreement