Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CMS render scss styling in tutor env #70

Merged
merged 1 commit into from Mar 6, 2024
Merged

fix: CMS render scss styling in tutor env #70

merged 1 commit into from Mar 6, 2024

Conversation

Talha-Rizwan
Copy link

@Talha-Rizwan Talha-Rizwan commented Feb 20, 2024 •
edited

  • *.scss files in cms were not rendered at all in the tutor environment because they are stored in a "partials" subdirectory.
  • added override styling for cms using _variables.scss and _extras.scss
  • added a customizable footer with styling as no custom footer was there for cms but for lms.

PR for #69

@Talha-Rizwan Talha-Rizwan marked this pull request as draft February 20, 2024 11:33
@Talha-Rizwan Talha-Rizwan self-assigned this Feb 20, 2024
@Talha-Rizwan Talha-Rizwan marked this pull request as ready for review February 20, 2024 13:03
@Talha-Rizwan
Copy link
Author

@hinakhadim changes are ready to review.

@hinakhadim
Copy link
Collaborator

Also, Can you make the tests pass as the tests are failing now?

@Danyal-Faheem
Copy link
Contributor

Danyal-Faheem commented Mar 6, 2024 •
edited

Also, Can you make the tests pass as the tests are failing now?

The tests are passing now after reformatting code.

I have also squashed the commits.

@hinakhadim hinakhadim merged commit 0b41135 into overhangio:master Mar 6, 2024
1 check passed
@hinakhadim
Copy link
Collaborator

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danyal-Faheem Danyal-Faheem Danyal-Faheem left review comments

@hinakhadim hinakhadim Awaiting requested review from hinakhadim

Assignees

@Talha-Rizwan Talha-Rizwan

Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Talha-Rizwan @hinakhadim @Danyal-Faheem