Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: improve c++ std space import. #3509

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

suzp1984
Copy link
Contributor

The namespace std is imported to srs_app_utility.cpp, but the string declaration is not inconsistent, some part use std::string, while other part use string.

And also the ::getenv(), makes me confused at the beginning.

The commit deletes the using namespace std;, I remember there is a coding convention that said to avoid importing the whole namespace in C++. What do you guys think about it?

@winlinvip
Copy link
Member

Thank you, we will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants