-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GeoScribble WMS overlay #2312
base: gh-pages
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
"EPSG:4326" | ||
], | ||
"max_zoom": 22, | ||
"name": "GeoScribble latest notes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "GeoScribble latest notes", | |
"name": "GeoScribble latest notes (Every Door)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not tie this to a single editor. Pretty sure we'll see this layer being populated from other apps before the year ends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, that might very well be. But it will be easy to update it here, once that happens. Right now, I don't see a way that a user would be able to understand where those GeoScribbles came from just by looking at the title and description in the iD Editor Sidebar. — Adding a bit more context helps a lot.
"transparent": true, | ||
"category": "other", | ||
"valid-georeference": true, | ||
"url": "https://geoscribble.osmz.ru/?FORMAT=image/png&TRANSPARENT=TRUE&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=latest&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly: openstreetmap/iD#9280
It does need background to work. Just like OSM GPS layer. That's why there's "overlay": true
key included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I get it now, thanks. I never really looked at the overlay-prop and feature in iD but looking at the code now this should show up in the overlay section. Nice.
Good idea, just did that.
In my experience, I either map surveyed things in a week, or forget about them altogether. There are three options:
Questions on whether:
|
re: osmlab/editor-layer-index#2312 We built a service for this in #1373, so we don't want it to also show up as a raster overlay
Co-authored-by: Tobias <t@tobiasjordans.de>
I believe i18n=true could be used, since the description would then be available to be translated ("what is GeoScribble?" some users might ask at first), and also given that the proposed name is "GeoScribble latest notes", this latest notes part can and should be translated as well to non-English speakers. |
See https://wiki.openstreetmap.org/wiki/GeoScribble — for editors that don't support the geometric notes yet.
Things to discuss:
default=true
?i18n=true
?