Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoScribble WMS overlay #2312

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

Zverik
Copy link
Contributor

@Zverik Zverik commented May 7, 2024

See https://wiki.openstreetmap.org/wiki/GeoScribble — for editors that don't support the geometric notes yet.

Things to discuss:

  • There is no explicit license mention, but the wiki page states it's PDDL. Should I put this license note somewhere else?
  • There are two layers: limited to 3 months and 3 weeks of notes. Does 3 weeks work?
  • default=true?
  • i18n=true?

@tordans

This comment was marked as resolved.

sources/world/GeoScribbles.geojson Outdated Show resolved Hide resolved
"EPSG:4326"
],
"max_zoom": 22,
"name": "GeoScribble latest notes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "GeoScribble latest notes",
"name": "GeoScribble latest notes (Every Door)",

Copy link
Contributor Author

@Zverik Zverik May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not tie this to a single editor. Pretty sure we'll see this layer being populated from other apps before the year ends.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, that might very well be. But it will be easy to update it here, once that happens. Right now, I don't see a way that a user would be able to understand where those GeoScribbles came from just by looking at the title and description in the iD Editor Sidebar. — Adding a bit more context helps a lot.

"transparent": true,
"category": "other",
"valid-georeference": true,
"url": "https://geoscribble.osmz.ru/?FORMAT=image/png&TRANSPARENT=TRUE&VERSION=1.1.1&SERVICE=WMS&REQUEST=GetMap&LAYERS=latest&STYLES=&SRS={proj}&WIDTH={width}&HEIGHT={height}&BBOX={bbox}",

This comment was marked as resolved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly: openstreetmap/iD#9280

It does need background to work. Just like OSM GPS layer. That's why there's "overlay": true key included.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I get it now, thanks. I never really looked at the overlay-prop and feature in iD but looking at the code now this should show up in the overlay section. Nice.

@Zverik
Copy link
Contributor Author

Zverik commented May 8, 2024

I suggest making it a bit more explicit by adding a section to the wiki and changing the link to https://wiki.openstreetmap.org/wiki/GeoScribble#licence

Good idea, just did that.

This is the age of the data that will show up? I think 3 month should be better since there will not be a lot of data to start with and moving from mobile to a different editor can take a bit of time…

In my experience, I either map surveyed things in a week, or forget about them altogether. There are three options:

  1. Keep it 3 weeks.
  2. Change to 3 months.
  3. Add two GeoScribble layers, one for weeks and one for months (that's the matter of layer= parameter).
  • default=true?
  • i18n=true?

What are those?

Questions on whether:

  • Include the layer in the defaults, like OSM GPS layer and Bing & Mapbox imagery.
  • Allow for translating the layer name and description.

bhousel added a commit to facebook/Rapid that referenced this pull request May 8, 2024
re: osmlab/editor-layer-index#2312

We built a service for this in #1373, so we don't want it to
also show up as a raster overlay
Co-authored-by: Tobias <t@tobiasjordans.de>
@matheusgomesms
Copy link
Collaborator

I believe i18n=true could be used, since the description would then be available to be translated ("what is GeoScribble?" some users might ask at first), and also given that the proposed name is "GeoScribble latest notes", this latest notes part can and should be translated as well to non-English speakers.

Co-authored-by: Matheus Gomes <86851490+matheusgomesms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants