Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NH GRANIT orthoimagery and lidar hillshade layers #2263

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

zekefarwell
Copy link
Contributor

This adds orthoimagery and lidar hillshade imagery layers for the US state of New Hamshire available from NH GRANIT, New Hampshire's statewide GIS clearinghouse. I've confirmed with NH GRANIT that these datasets are available in the public domain and have no restrictions on their use (documented on the OSM wiki here). I've added these same layers to the JOSM imagery sources as well.

@cicku cicku self-assigned this Apr 1, 2024
@cicku
Copy link
Collaborator

cicku commented Apr 1, 2024

Will get this reviewed in 2 weeks.

@cicku
Copy link
Collaborator

cicku commented Apr 9, 2024

Please fix the error based on check result.

@zekefarwell
Copy link
Contributor Author

OK I've added the available projections to fix the CI check. I wouldn't have understood how to find those, but a maintainer added them to the JOSM index so I copied them over.

Looks like now the CI check is throwing a different error. Seems like maybe a multipolygon is not allowed for for the geometry?

@zekefarwell zekefarwell changed the title Add NH GRANIT othorimagery and lidar hillshade layers Add NH GRANIT orthoimagery and lidar hillshade layers Apr 17, 2024
@zekefarwell
Copy link
Contributor Author

I figured out the geometry proplem and pushed a fix for that. Unfortunately now there are several more errors. It's saying the geojson ring orientation is incorrect and no connection adapters found for WMS servers. I'm not sure what needs to be done to fix these errors. The geojson files seem to load up just fine on geojson.io

@zekefarwell
Copy link
Contributor Author

Ok looks like I've managed to resolve all the geometry problems. Now there's just the "no connection adapters found for WMS servers" error. I don't know what this means but am happy to fix it if you can point me in the right direction.

Copy link
Contributor

@arch0345 arch0345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be where the error is coming from

Co-authored-by: archpdx <archpdx@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants