remove unused transitive dependency to info.picocli:picocli #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently there is a transitive dependency to picocli (https://picocli.info/) library that is used to handle CLI arguments, which is brought by com.puppycrawl.tools:checkstyle lib. The functionality of CLI handling is not used and I think it's an error that checkstyle exports it in first place, because usually checkstyle is used as a library, not a CLI application. Anyway picocli is not used in atlas, and also shouldn't be exported further to atlas users. So this dependency is excluded from the checkstyle dependency.
Potential Impact:
In case downstream users are CLI applications and they don't depend explicitly on picocli, they will need to do so after this change (which is actually the correct way). If this situation occurs, the fix is trivial.
Unit Test Approach:
No unit tests are needed, because there's no logic change.
Test Results:
N/A